Add 'beacon_' prefix to PeerDAS metrics names #6537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
reviewed
Nov 5, 2024
jimmygchen
reviewed
Nov 5, 2024
jimmygchen
requested changes
Nov 5, 2024
Member
jimmygchen
left a comment
There was a problem hiding this comment.
Thanks @KatyaRyazantseva, the prefix make sense, just one minor comment here to update a few other related metrics.
jimmygchen
approved these changes
Jan 7, 2025
Member
jimmygchen
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @KatyaRyazantseva !
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 57141d8 |
This was referenced Jan 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This PR addresses issue #6018, the list of the PeerDAS metrics. PeerDAS metrics specs PR
Proposed Changes
Added
beacon_prefix to metrics names to align with PeerDAS metrics specs.