VC: use block publication v2 SSZ API#6523
Merged
mergify[bot] merged 1 commit intosigp:unstablefrom Oct 21, 2024
Merged
Conversation
macladson
approved these changes
Oct 21, 2024
Member
macladson
left a comment
There was a problem hiding this comment.
Nice! I agree with your comments regarding SSZ as well 👍
Member
Author
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at b88cb8c |
5 tasks
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* VC: use block publication v2 SSZ API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Prepare for the removal of the v1 block publishing API:
Proposed Changes
Switch the VC over to using the v2 version of the block publication API, with the default
broadcast_validation=gossip(equivalent to current behaviour).While making the change, I think we should also switch to sending SSZ rather than JSON. This should be slightly quicker for the BN to decode.
Testing
The simulator tests cover the interaction between current versions of the Lighthouse VC and BN. We can conduct further testing as part of the v6.0.0 release rollout on testnet infra.
Additional Info
We could guard the use of SSZ behind a new flag, but this feels somewhat unnecessary. Lighthouse BN has no issue with SSZ, and other clients have also supported it on this endpoint for a long time. This change is somewhat overdue.