Closed
Conversation
pscott
commented
Dec 4, 2019
| // Retrieving the corresponding ValidatorDir | ||
| let validator = match validators.get(validator_pubkey) { | ||
| Some(validator) => validator, | ||
| None => return None, |
Contributor
Author
There was a problem hiding this comment.
Maybe we should log something here if it returns None, stating that the validator_pubkey doesn't appear amongst the validators?
pscott
commented
Dec 4, 2019
| let is_slashing_free = validator | ||
| .block_slashing_protection | ||
| .as_ref()? | ||
| .try_lock()? |
Contributor
Author
There was a problem hiding this comment.
What should we do here if it fails?
pscott
commented
Dec 4, 2019
| let is_slashing_free = validator | ||
| .attestation_slashing_protection | ||
| .as_ref()? | ||
| .try_lock()? |
Contributor
Author
There was a problem hiding this comment.
What should we do here if it fails?
Member
|
I'm still keen to get this merged, I'm just dealing with some more immediate sync-speed issues at the moment. Please bear with me! :) |
michaelsproul
pushed a commit
that referenced
this pull request
Apr 24, 2020
Roll-up of #588 with some conflicts resolved
4 tasks
Member
michaelsproul
added a commit
that referenced
this pull request
May 18, 2020
* Implement slashing protection Roll-up of #588 with some conflicts resolved * WIP improvements * Require slot uniqueness for blocks (rather than epochs) * Native DB support for Slot and Epoch * Simplify surrounding/surrounded-by queries * Implement unified slashing protection database A single SQL database saves on open file descriptors. * Make slashing protection concurrency safe. Revive tests, add parallel tests. * Some simplifications * Auto-registration, test clean-ups * More tests, clean-ups, hardening * Fix comments in BLS * Optimise bulk validator registration * Delete outdated tests * Use bundled SQLite in slashing protection * Auto-register validators in simulation * Use real signing_root in slashing protection * Update book for --auto-register * Refine log messages and help flags * Correct typo in Cargo.toml authors * Fix merge conflicts * Safer error handling in sqlite slot/epoch * Address review comments * Add attestation test mutating block root Co-authored-by: pscott <scottpiriou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #254
Closes #623
Proposed Changes
Additional info
Added some comments on github for things I'm unsure about.
Please see this hackmd note that explains the slashing protection implementation.