Do not drop lookups without peers while awaiting events#5839
Merged
mergify[bot] merged 1 commit intosigp:unstablefrom May 24, 2024
Merged
Do not drop lookups without peers while awaiting events#5839mergify[bot] merged 1 commit intosigp:unstablefrom
mergify[bot] merged 1 commit intosigp:unstablefrom
Conversation
realbigsean
approved these changes
May 24, 2024
Member
realbigsean
left a comment
There was a problem hiding this comment.
Seems like a good approach to fixing this bug
Member
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
5 tasks
Member
|
@mergify refresh |
✅ Pull request refreshed |
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at f187ad8 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Lookups without peers should be allowed to exist for some time. See this common race condition:
In step 4 we could drop the lookup because we attempt to issue a request with no peers available. This has two issues:
drop_lookup_and_children.Instead, there's no negative for keeping lookups with no peers around for some time. If we regularly prune them, it should not be a memory concern (TODO: maybe yes!).
This PR fixes the race condition seen in first issue of:
Proposed Changes
Do not immediately drop a lookup when attempting to do a download and it has no peers. Instead wait for all the following conditions before dropping it: