Use JSON header by default for /eth/v1/beacon/deposit_snapshot#5813
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom May 20, 2024
Merged
Use JSON header by default for /eth/v1/beacon/deposit_snapshot#5813mergify[bot] merged 2 commits intosigp:unstablefrom
/eth/v1/beacon/deposit_snapshot#5813mergify[bot] merged 2 commits intosigp:unstablefrom
Conversation
michaelsproul
approved these changes
May 20, 2024
Member
michaelsproul
left a comment
There was a problem hiding this comment.
Looks great, thanks CK!
Member
|
Marked this as backwards-incompat so we remember to mention it in the release notes. Some software that is sending the |
Member
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at b5de925 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of current Lighthouse beacon API uses JSON by default when the header is not specified in querying the beacon API. The
/eth/v1/beacon/deposit_snapshotuses SSZ when the header is not specified. This PR changes it to use JSON to be consistent with others.Thanks @michaelsproul for the guidance.