Do not request current child lookup peers#5724
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom May 13, 2024
Merged
Conversation
7269d79 to
c55dd1b
Compare
c55dd1b to
a356c75
Compare
michaelsproul
added a commit
that referenced
this pull request
May 7, 2024
Squashed commit of the following: commit a356c75 Author: dapplion <35266934+dapplion@users.noreply.github.com> Date: Tue May 7 00:50:54 2024 +0900 Do not request current child lookup peers
Merged
3073087 to
f30dd96
Compare
dapplion
commented
May 13, 2024
| } | ||
|
|
||
| #[test] | ||
| fn parent_block_and_blob_lookup_child_returned_first_blob_trigger() { |
Collaborator
Author
There was a problem hiding this comment.
Not possible now, child is not requested until parent is imported
| } | ||
|
|
||
| #[test] | ||
| fn parent_block_and_blob_lookup_child_returned_first() { |
Collaborator
Author
There was a problem hiding this comment.
Not possible now, child is not requested until parent is imported
| } | ||
|
|
||
| #[test] | ||
| fn test_skip_creating_failed_current_lookup() { |
Collaborator
Author
There was a problem hiding this comment.
Not applicable anymore. A peer makes no claim that it has imported the child block, so it should not be downscored
| } | ||
|
|
||
| #[test] | ||
| fn test_parent_lookup_empty_response() { |
Collaborator
Author
There was a problem hiding this comment.
Duplicated test, child and parent logic are the same now
f30dd96 to
0b340b0
Compare
realbigsean
approved these changes
May 13, 2024
Member
|
great simplification ! |
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at f37ffe4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Description of the problem ⬇️
Proposed Changes
Implement solution 1 from #5707
Todo
Closes #5707