Delete repetitive execute command in local testnet scripts#5611
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom Apr 22, 2024
Merged
Delete repetitive execute command in local testnet scripts#5611mergify[bot] merged 2 commits intosigp:unstablefrom
mergify[bot] merged 2 commits intosigp:unstablefrom
Conversation
michaelsproul
approved these changes
Apr 21, 2024
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at ad7f0e0 |
This was referenced Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very minor bug in the local-testnet script where the
el_bootnode.shis executed twice, causing the outcome that whenstop_local_testnet.shis called, the terminal will show:./kill_processes.sh: line 15: kill: (2254405) - No such processIt doesn't really affect anything though, but it would be nice to delete this so that no error is shown when the testnet is stopped.