Fix on-disk consensus context format#5598
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom Apr 19, 2024
Merged
Conversation
realbigsean
requested changes
Apr 18, 2024
| parent_eth1_finalization_data: Eth1FinalizationData, | ||
| confirmed_state_roots: Vec<Hash256>, | ||
| consensus_context: ConsensusContext<E>, | ||
| consensus_context: OnDiskConsensusContext, |
Member
There was a problem hiding this comment.
DietAvailabilityPendingExecutedBlock is constructued on every block, and since OnDiskConsensusContext drops indexed_attestations, that cache would be dropped every block.
Could fix this easily by keeping the indexed_attestations field in OnDiskConsensusContext with #[ssz(skip_serializing, skip_deserializing)].
Member
Author
There was a problem hiding this comment.
Great catch, just pushed a fix
Member
Author
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 5a9e973 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix a regression in
unstablethat causes logs of the form:This was due to the addition of fields to
ConsensusContextin the single-pass epoch processing PR.ConsensusContextis now part of our on-disk database schema viaDietAvailabilityPendingExecutedBlock:lighthouse/beacon_node/beacon_chain/src/data_availability_checker/state_lru_cache.rs
Lines 20 to 30 in 3058b96
Proposed Changes
OnDiskConsensusContextstruct which keeps only the previous fields.