Skip to content

Set web3signer keep-alive to 20s by default#5587

Merged
mergify[bot] merged 2 commits intosigp:unstablefrom
michaelsproul:default-web3-signer-timeout
Apr 17, 2024
Merged

Set web3signer keep-alive to 20s by default#5587
mergify[bot] merged 2 commits intosigp:unstablefrom
michaelsproul:default-web3-signer-timeout

Conversation

@michaelsproul
Copy link
Member

Issue Addressed

Follow-up to:

Proposed Changes

Set the default keep-alive to 20s, which is shorter than web3signer's default 30s.

Several of our users are successfully making use of this flag now, so I think it makes sense to set the default to a value that works. CC @guybrush (of EthPool/beaconcha.in)

@michaelsproul michaelsproul added val-client Relates to the validator client binary ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! UX-and-logs labels Apr 16, 2024
@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 16, 2024
@realbigsean
Copy link
Member

@mergify queue

@mergify
Copy link

mergify bot commented Apr 16, 2024

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@realbigsean
Copy link
Member

@mergify requeue

@mergify
Copy link

mergify bot commented Apr 16, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented Apr 16, 2024

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Apr 16, 2024
@michaelsproul
Copy link
Member Author

@Mergifyio requeue

@mergify
Copy link

mergify bot commented Apr 16, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@michaelsproul
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link

mergify bot commented Apr 16, 2024

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Apr 16, 2024
@realbigsean
Copy link
Member

@mergify requeue

@mergify
Copy link

mergify bot commented Apr 17, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented Apr 17, 2024

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 49617f3

mergify bot added a commit that referenced this pull request Apr 17, 2024
@mergify mergify bot merged commit 49617f3 into sigp:unstable Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. UX-and-logs val-client Relates to the validator client binary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants