Restore Log on Error & Spawn Blocking in Streamer#5585
Merged
mergify[bot] merged 5 commits intosigp:unstablefrom Apr 16, 2024
Merged
Restore Log on Error & Spawn Blocking in Streamer#5585mergify[bot] merged 5 commits intosigp:unstablefrom
mergify[bot] merged 5 commits intosigp:unstablefrom
Conversation
realbigsean
requested changes
Apr 16, 2024
Member
realbigsean
left a comment
There was a problem hiding this comment.
I like the logging message structure being standard across all these responses, howeve looks like blobs by root was missed because it required no other logging change, could I request its message be updated to:
BlobsByRoot outgoing response processed
beacon_node/network/src/network_beacon_processor/rpc_methods.rs
Outdated
Show resolved
Hide resolved
beacon_node/network/src/network_beacon_processor/rpc_methods.rs
Outdated
Show resolved
Hide resolved
beacon_node/network/src/network_beacon_processor/rpc_methods.rs
Outdated
Show resolved
Hide resolved
beacon_node/network/src/network_beacon_processor/rpc_methods.rs
Outdated
Show resolved
Hide resolved
Member
Author
done! |
realbigsean
approved these changes
Apr 16, 2024
Member
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at f689898 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
BeaconBlockStreamernow runs the task of loading the blocks in a blocking thread as DB reads are slow