Nest lookup type into request id SingleBlock and SingleBlob#5562
Merged
mergify[bot] merged 1 commit intosigp:unstablefrom Apr 11, 2024
Merged
Nest lookup type into request id SingleBlock and SingleBlob#5562mergify[bot] merged 1 commit intosigp:unstablefrom
mergify[bot] merged 1 commit intosigp:unstablefrom
Conversation
Member
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 34dbb32 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Part of:
It's unnecessary to have distinct RequestIds for parent and current block lookups. The router does not need to be concerned with this distinction, only the block lookups struct needs to know where to route the response.
Proposed Changes
Nest lookup type into request id SingleBlock and SingleBlob.
This PR does not change any sync logic. It fixes a typo in the test
no_peer_penalty_when_rpc_response_already_known_from_gossipwhich was fetching the wrong ID