Sync lookup dedup range and blobs#5561
Conversation
realbigsean
left a comment
There was a problem hiding this comment.
@realbigsean please look into this line change https://github.com/sigp/lighthouse/pull/5561/files#diff-3d6c8081703730f63787240a11f38fdde1d721397245cf316207b108f1df3defR962 to ensure it does not regress this fix #4869
looks like the logic there is unchanged 👌
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
@Mergifyio requeue |
✅ This pull request will be re-embarked automaticallyDetailsThe followup |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 6fb0b2e |
Issue Addressed
Part of
Proposed Changes
Merges BackFillBlocks, BackFillBlockAndBlobs, RangeBlocks, RangeBlockAndBlobs handling. All those requests return the same type of data, a Vec, which can be handled with an enum request id to differentiate RangeSync from BackfillSync.
Pre-deneb requests of only blocks and post-deneb requests of blocks and blobs can be handled together by tracking if a blobs request has been sent.
This PR does not change any logic or behaviour of either sync, nor their tests. @realbigsean please look into this line change https://github.com/sigp/lighthouse/pull/5561/files#diff-3d6c8081703730f63787240a11f38fdde1d721397245cf316207b108f1df3defR962 to ensure it does not regress this fix #4869