Skip to content

Update Simulator tests#5520

Merged
mergify[bot] merged 12 commits intosigp:unstablefrom
macladson:update-simulator
Apr 22, 2024
Merged

Update Simulator tests#5520
mergify[bot] merged 12 commits intosigp:unstablefrom
macladson:update-simulator

Conversation

@macladson
Copy link
Member

@macladson macladson commented Apr 4, 2024 •
edited
Loading

Issue Addressed

#5173

Proposed Changes

Adds fork compatibility up to Deneb (and Electra). This includes a basic check that each post-Deneb block has available blobs. no-eth1-sim has been removed, and the sync-sim has been simplified into a single check in the basic-sim.

This also removes compatibility with pre-Bellatrix forks since Genesis now starts pre-merged.
This should hopefully allow us to remove Anvil as a dependency soon, although there is still a lot of older Eth1 code that will need to be reworked/removed.

Usage

cd testing/simulator
cargo run --release --bin simulator basic-sim

@macladson macladson added the work-in-progress PR is a work-in-progress label Apr 4, 2024
@realbigsean realbigsean mentioned this pull request Apr 11, 2024
Closed
@macladson macladson added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Apr 15, 2024
@realbigsean realbigsean self-requested a review April 16, 2024 17:20
@realbigsean realbigsean added under-review A reviewer has only partially completed a review. and removed ready-for-review The code is ready for review labels Apr 17, 2024
realbigsean
realbigsean requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty much good to go! Just a couple minor comments

@realbigsean realbigsean added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed under-review A reviewer has only partially completed a review. labels Apr 17, 2024
@macladson
Copy link
Member Author

macladson commented Apr 18, 2024

Thanks! I also added the block production check to the fallback-sim since full block production is also indicative of the fallback mechanism working properly.

@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 18, 2024
realbigsean
realbigsean approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's send it!

@realbigsean
Copy link
Member

realbigsean commented Apr 22, 2024

@mergify queue

@mergify
Copy link

mergify bot commented Apr 22, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 22, 2024
mergify bot added a commit that referenced this pull request Apr 22, 2024
@mergify
Merge of #5520
6fb74d9
@mergify mergify bot mentioned this pull request Apr 22, 2024
Closed
5 tasks
@realbigsean
Copy link
Member

realbigsean commented Apr 22, 2024

@mergify requeue

@mergify
Copy link

mergify bot commented Apr 22, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented Apr 22, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 67f8405

mergify bot added a commit that referenced this pull request Apr 22, 2024
@mergify
Merge of #5520
e7bf988
@mergify mergify bot mentioned this pull request Apr 22, 2024
Closed
5 tasks
@mergify mergify bot merged commit 67f8405 into sigp:unstable Apr 22, 2024
@jimmygchen jimmygchen mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realbigsean realbigsean realbigsean approved these changes

Assignees

No one assigned

Labels

ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@macladson @realbigsean @dapplion