Deprecate `http-spec-fork` and `http-allow-sync-stalled` by eserilev · Pull Request #5500 · sigp/lighthouse

eserilev · 2024-03-27T22:22:44Z

Issue Addressed

#5430

Proposed Changes

Deprecate http-spec-fork
The default spec fork is now always chosen

Deprecate http-allow-sync-stalled
Remove allow_sync_stalled flag. Sync is now allowed by default

The issue description has justifications for these changes

chong-he · 2024-03-28T00:36:21Z

scripts/local_testnet/beacon_node.sh

@@ -67,5 +67,4 @@ exec $lighthouse_binary \
 	--target-peers $((BN_COUNT - 1)) \
  --execution-endpoint $execution_endpoint \
  --execution-jwt $execution_jwt \


Do we want to remove the backlash in the previous line?

Suggested change

--execution-jwt $execution_jwt \

--execution-jwt $execution_jwt

thanks, removed in a3e4f5e

no, we need to keep it because $BN_ARGS is on the next line

book/src/help_bn.md

…precate-http-spec-fork-and-http-allow-sync-stalled

beacon_node/src/config.rs

michaelsproul

LGTM

Will merge with these few tiny fixes applied

scripts/local_testnet/beacon_node.sh

beacon_node/src/cli.rs

…ec-fork-and-http-allow-sync-stalled

michaelsproul · 2024-04-11T01:05:32Z

@Mergifyio queue

mergify · 2024-04-11T01:05:37Z

queue

🛑 The pull request has been removed from the queue `default`

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

michaelsproul · 2024-04-12T01:38:43Z

@Mergifyio requeue

mergify · 2024-04-12T01:38:50Z

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-04-12T01:38:51Z

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 6bac5ce

eserilev added 2 commits March 28, 2024 00:15

deprecate flags

275c6cb

fmt

84120c4

chong-he reviewed Mar 28, 2024

View reviewed changes

remove backslash

a3e4f5e

eserilev added the ready-for-review The code is ready for review label Apr 1, 2024

michaelsproul reviewed Apr 1, 2024

View reviewed changes

book/src/help_bn.md Outdated Show resolved Hide resolved

eserilev added 2 commits April 4, 2024 01:00

remove hidden flags from the book

da14923

Merge branch 'unstable' of https://github.com/sigp/lighthouse into de…

bb92668

…precate-http-spec-fork-and-http-allow-sync-stalled

michaelsproul reviewed Apr 4, 2024

View reviewed changes

beacon_node/src/config.rs Show resolved Hide resolved

michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Apr 4, 2024

add warn, re-add tests

60bd574

michaelsproul approved these changes Apr 10, 2024

View reviewed changes

scripts/local_testnet/beacon_node.sh Outdated Show resolved Hide resolved

beacon_node/src/cli.rs Outdated Show resolved Hide resolved

michaelsproul and others added 3 commits April 11, 2024 09:24

Apply suggestions from code review

0193496

Merge remote-tracking branch 'origin/unstable' into deprecate-http-sp…

d7fd440

…ec-fork-and-http-allow-sync-stalled

Fix imports

908d5c6

michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 11, 2024

mergify bot added a commit that referenced this pull request Apr 12, 2024

Merge of #5500

bc9c827

mergify bot mentioned this pull request Apr 12, 2024

merge queue: embarking unstable (d30ba97) and #5500 together #5571

Closed

5 tasks

mergify bot merged commit 6bac5ce into sigp:unstable Apr 12, 2024

jimmygchen mentioned this pull request May 1, 2024

Deprecate http-spec-fork and http-allow-sync-stalled #5430

Closed

michaelsproul mentioned this pull request May 2, 2024

InvalidSignature errors caused by race between duties & attestation data #5687

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate `http-spec-fork` and `http-allow-sync-stalled`#5500

Deprecate `http-spec-fork` and `http-allow-sync-stalled`#5500
mergify[bot] merged 9 commits intosigp:unstablefrom
eserilev:deprecate-http-spec-fork-and-http-allow-sync-stalled

eserilev commented Mar 27, 2024

Uh oh!

chong-he Mar 28, 2024

Uh oh!

eserilev Mar 28, 2024

Uh oh!

michaelsproul Apr 10, 2024

Uh oh!

Uh oh!

Uh oh!

michaelsproul left a comment

Uh oh!

Uh oh!

Uh oh!

michaelsproul commented Apr 11, 2024

Uh oh!

mergify bot commented Apr 11, 2024 •

edited

Loading

Uh oh!

michaelsproul commented Apr 12, 2024

Uh oh!

mergify bot commented Apr 12, 2024

Uh oh!

mergify bot commented Apr 12, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	--execution-jwt $execution_jwt \
	--execution-jwt $execution_jwt

Conversation

eserilev commented Mar 27, 2024

Issue Addressed

Proposed Changes

Uh oh!

chong-he Mar 28, 2024

Choose a reason for hiding this comment

Uh oh!

eserilev Mar 28, 2024

Choose a reason for hiding this comment

Uh oh!

michaelsproul Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

michaelsproul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

michaelsproul commented Apr 11, 2024

Uh oh!

mergify bot commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛑 The pull request has been removed from the queue default

Uh oh!

michaelsproul commented Apr 12, 2024

Uh oh!

mergify bot commented Apr 12, 2024

✅ This pull request will be re-embarked automatically

Uh oh!

mergify bot commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ The pull request has been merged automatically

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mergify bot commented Apr 11, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented Apr 12, 2024 •

edited

Loading