Conversation
| .uor(post_beacon_blinded_blocks_v2_ssz) | ||
| .boxed(), | ||
| ) | ||
| .boxed() |
There was a problem hiding this comment.
I feel like this is the critical one, although I feel like the handler/filter shouldn't be too massive at this point as it is basically:
post().and(header_exact.and(boxed_handler))which would have a type something like:
And<Post, And<HeaderExact, Boxed<Filter<..>>>The size of this object on the stack does not seem to me like it should be large. An And is only as large as its two elements added together:
The fact we've already boxed most of the handler should help here, I would think.
There was a problem hiding this comment.
Thinking it may be more related to the stack size of the futures created by the filters when they execute:
AFAICT both request and response are boxed anyway
|
I'll push my changes here |
This reverts commit cd3dde7.
|
I've just reverted cd3dde7 at Michael's suggestion. We're going to start testing this on our infra as a possible candidate for v4.6.0. |
Squashed commit of the following: commit 2653bee Author: Paul Hauner <paul@paulhauner.com> Date: Mon Jan 22 13:55:31 2024 +1100 Revert "remove a couple boxes" This reverts commit cd3dde7. commit cd3dde7 Author: realbigsean <seananderson33@GMAIL.com> Date: Tue Jan 16 18:03:24 2024 -0500 remove a couple boxes commit 8617ac2 Author: realbigsean <seananderson33@GMAIL.com> Date: Tue Jan 16 16:37:03 2024 -0500 box ssz publish
Squashed commit of the following: commit 2653bee Author: Paul Hauner <paul@paulhauner.com> Date: Mon Jan 22 13:55:31 2024 +1100 Revert "remove a couple boxes" This reverts commit cd3dde7. commit cd3dde7 Author: realbigsean <seananderson33@GMAIL.com> Date: Tue Jan 16 18:03:24 2024 -0500 remove a couple boxes commit 8617ac2 Author: realbigsean <seananderson33@GMAIL.com> Date: Tue Jan 16 16:37:03 2024 -0500 box ssz publish
|
Closing in favour of #5104 |
Issue Addressed
When publishing a full block via the SSZ V2 endpoint, we get a stack overflow, it seems to be caused by this: seanmonstar/warp#811
Added
.boxed()has fixed it for me testing on kurtosis. I've probably added more than necessary, but being a bit conservative.