Skip to content

Move from igd to igd-next#5068

Merged
mergify[bot] merged 2 commits intosigp:unstablefrom
ackintosh:move-from-igd-to-igd-next
Jan 31, 2024
Merged

Move from igd to igd-next#5068
mergify[bot] merged 2 commits intosigp:unstablefrom
ackintosh:move-from-igd-to-igd-next

Conversation

@ackintosh
Copy link
Member

Issue Addressed

Closes #5020

Proposed Changes

Move from igd to igd-next v0.14.3, which contains fix for the panic issue.

Additional Info

  • igd is no longer maintained and igd-next is a fork
  • the patch for the panic issue has been merged and released as igd-next v0.14.3

warning: useless conversion to the same type: `std::net::IpAddr`
@ackintosh ackintosh requested review from AgeManning and jxs January 15, 2024 07:05
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Will wait for @jxs to have a look also

@dapplion dapplion added the ready-for-review The code is ready for review label Jan 29, 2024
@jxs
Copy link
Member

jxs commented Jan 31, 2024

Thanks Akihito!

@AgeManning
Copy link
Member

@Mergifyio queue

@mergify
Copy link

mergify bot commented Jan 31, 2024

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at b9c519d

mergify bot added a commit that referenced this pull request Jan 31, 2024
@mergify mergify bot merged commit b9c519d into sigp:unstable Jan 31, 2024
@ackintosh ackintosh deleted the move-from-igd-to-igd-next branch February 2, 2024 05:41
danielrachi1 pushed a commit to danielrachi1/lighthouse that referenced this pull request Feb 14, 2024
* Move from igd to igd-next

* Fix clippy error

warning: useless conversion to the same type: `std::net::IpAddr`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants