Skip to content

Investigate UnknownTargetRoot slasher errors#5006

Merged
mergify[bot] merged 1 commit intosigp:unstablefrom
armaganyildirak:unknown-target-root
Jun 4, 2024
Merged

Investigate UnknownTargetRoot slasher errors#5006
mergify[bot] merged 1 commit intosigp:unstablefrom
armaganyildirak:unknown-target-root

Conversation

@armaganyildirak
Copy link
Member

@armaganyildirak armaganyildirak commented Dec 13, 2023 •
edited
Loading

Issue Addressed

#4972

Proposed Changes

This PR addresses the issue where attestations failing with UnknownHeadBlock are incorrectly processed through the slasher, leading to subsequent failures in signature verification (SignatureNotChecked) The subsequent failure occurs when attempting to load the state for the target block. This is expected when the target is identical to the head, leading to an unknown state. The proposed solution involves requeuing attestations without involving the slasher when encountering UnknownHeadBlock.

Some UnknownTargetRoot errors could still occur particularly during startup. It happens when the beacon_block_root slot is later than target_root slot. However they are harmless because the requeueing will usually take care of processing them later.

Additional Info

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v5.2.0 Q2 2024 and removed work-in-progress PR is a work-in-progress labels Jun 4, 2024
michaelsproul
michaelsproul approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul
Copy link
Member

michaelsproul commented Jun 4, 2024

@Mergifyio queue

@mergify
Copy link

mergify bot commented Jun 4, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jun 4, 2024
@mergify
Merge of #5006
e9e8183
@mergify mergify bot mentioned this pull request Jun 4, 2024
Closed
5 tasks
@michaelsproul michaelsproul mentioned this pull request Jun 4, 2024
Merged
@jimmygchen
Copy link
Member

jimmygchen commented Jun 4, 2024

@mergify requeue

@mergify
Copy link

mergify bot commented Jun 4, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented Jun 4, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jun 4, 2024
@mergify
Merge of #5006
d9371fa
This was referenced Jun 4, 2024
Closed
Merged
mergify bot added a commit that referenced this pull request Jun 4, 2024
@mergify
Merge of #5006
4a3d1a8
@mergify mergify bot mentioned this pull request Jun 4, 2024
Closed
5 tasks
michaelsproul added a commit that referenced this pull request Jun 4, 2024
@michaelsproul
Investigate UnknownTargetRoot slasher errors (#5006)
43c4c1f 
Squashed commit of the following:

commit 7adfecc
Author: armaganyildirak <armaganyildirak@gmail.com>
Date:   Wed Dec 13 15:22:02 2023 -0500

    Fix the UnknownTargetRoot
@michaelsproul michaelsproul mentioned this pull request Jun 4, 2024
Merged
@jimmygchen
Copy link
Member

jimmygchen commented Jun 4, 2024

@mergify requeue

@mergify
Copy link

mergify bot commented Jun 4, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented Jun 4, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 8a247eb

mergify bot added a commit that referenced this pull request Jun 4, 2024
@mergify
Merge of #5006
3d9c253
This was referenced Jun 4, 2024
Closed
Merged
@mergify mergify bot merged commit 8a247eb into sigp:unstable Jun 4, 2024
@michaelsproul michaelsproul mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees

No one assigned

Labels

ready-for-merge This PR is ready to merge. slasher UX-and-logs v5.2.0 Q2 2024

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@armaganyildirak @michaelsproul @jimmygchen