[Merged by Bors] - Fix genesis state download panic when running in debug mode#4753
[Merged by Bors] - Fix genesis state download panic when running in debug mode#4753jimmygchen wants to merge 3 commits intosigp:unstablefrom
Conversation
| bn_matches, | ||
| eth2_network_config, | ||
| log, | ||
| ))?; |
There was a problem hiding this comment.
Move config parsing and dumping into server::run as they need to be async.
| .map(|state| state.genesis_validators_root()) | ||
| .map(Result::Ok) | ||
| .transpose() | ||
| self.get_genesis_state_from_bytes::<E>() |
There was a problem hiding this comment.
Switching to the new sync get_genesis_state_from_bytes method, as we don't need to download genesis state and genesis_state method is now async.
|
Looks like there's a small type issue in the |
Thanks! this one is slightly annoying as it's only an issue on the |
|
I've just fixed a copy paste bug I introduced ...tests should pass now 🤞 |
|
I've tested running this branch on |
|
Marking this as |
paulhauner
left a comment
There was a problem hiding this comment.
Very nice! I like the simplification for getting the genesis validators root.
|
bors r+ |
|
Build failed (retrying...): |
It was @michaelsproul's idea! I like it too |
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
See the above issue for details. Went with option #2 to use the async reqwest client in `Eth2NetworkConfig` and propagate the async-ness.
See the above issue for details. Went with option #2 to use the async reqwest client in `Eth2NetworkConfig` and propagate the async-ness.
Issue Addressed
#4738
Proposed Changes
See the above issue for details. Went with option #2 to use the async reqwest client in
Eth2NetworkConfigand propagate the async-ness.