[Merged by Bors] - Support SSZ request body for POST /beacon/blinded_blocks endpoints (v1 & v2) by eserilev · Pull Request #4504 · sigp/lighthouse

eserilev · 2023-07-13T22:14:03Z

Issue Addressed

#4262

Proposed Changes

add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2)

Additional Info

…inded-beacon-block-ssz

paulhauner · 2023-07-20T00:12:28Z

Hey @eserilev this one is failing clippy. You can check locally with make lint :)

Edit: Merging in unstable might help with some new clippy lints added in a recent Rust version.

paulhauner

I started a review, but then realised that this will conflict with #4479 so I'll wait for that to be merged before finishing the review here :)

paulhauner · 2023-07-20T05:19:01Z

beacon_node/http_api/src/lib.rs

+                                    StatusCode::INTERNAL_SERVER_ERROR,
+                                    eth2::StatusCode::INTERNAL_SERVER_ERROR,


As above regarding BAD_REQUEST.

paulhauner · 2023-07-20T05:19:19Z

beacon_node/http_api/src/lib.rs

+                                return Err(warp_utils::reject::custom_server_error(format!(
+                                    "{:?}",
+                                    e
+                                )))


As mentioned in https://github.com/sigp/lighthouse/pull/4479/files#r1268939832, I think this would be best as a BAD_REQUEST.

paulhauner · 2023-07-20T05:21:08Z

Blocked on #4479

eserilev · 2023-08-01T06:39:06Z

this should now be unblocked

paulhauner

Looks good, thanks for another great contribution! ❤️

paulhauner · 2023-08-02T23:11:36Z

bors r+

…1 & v2) (#4504) ## Issue Addressed #4262 ## Proposed Changes add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2) ## Additional Info

bors · 2023-08-02T23:23:22Z

Build failed (retrying...):

debug-tests-ubuntu

…1 & v2) (#4504) ## Issue Addressed #4262 ## Proposed Changes add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2) ## Additional Info

bors · 2023-08-02T23:50:35Z

Build failed (retrying...):

release-tests-windows

divagant-martian · 2023-08-03T00:11:15Z

There seems to be a real failure here https://github.com/sigp/lighthouse/actions/runs/5723449067/job/15545145105

PRs batched with this one seem to be failing because of that and link directly to this

paulhauner · 2023-08-03T00:39:34Z

bors r-

bors · 2023-08-03T00:39:37Z

Canceled.

eserilev · 2023-08-04T15:30:16Z

There seems to be a real failure here https://github.com/sigp/lighthouse/actions/runs/5723449067/job/15545145105

PRs batched with this one seem to be failing because of that and link directly to this

Is this PR causing the issue? I tried running the test suite locally and i'm not getting any errors, but maybe I'm missing something here

paulhauner · 2023-08-06T23:47:52Z

I'll try CI again and see how it goes 🤞 We seem to be running into the same problem we're trying to fix in #4554.

paulhauner · 2023-08-07T00:33:12Z

Hmm, CI seems OK. I'll try bors again. Perhaps the issue only presents itself when unstable is merged with this branch.

bors r+

…1 & v2) (#4504) ## Issue Addressed #4262 ## Proposed Changes add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2) ## Additional Info

bors · 2023-08-07T00:46:16Z

Build failed (retrying...):

release-tests-ubuntu

…1 & v2) (#4504) ## Issue Addressed #4262 ## Proposed Changes add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2) ## Additional Info

bors · 2023-08-07T02:14:17Z

Build failed:

release-tests-windows

paulhauner · 2023-08-07T02:20:16Z

bors r+

…1 & v2) (#4504) ## Issue Addressed #4262 ## Proposed Changes add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2) ## Additional Info

bors · 2023-08-07T02:51:45Z

Build failed:

release-tests-windows

paulhauner · 2023-08-07T05:15:12Z

bors r+

…1 & v2) (#4504) ## Issue Addressed #4262 ## Proposed Changes add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2) ## Additional Info

bors · 2023-08-07T06:09:46Z

Build failed:

release-tests-ubuntu

paulhauner · 2023-08-07T22:52:47Z

bors r+

…1 & v2) (#4504) ## Issue Addressed #4262 ## Proposed Changes add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2) ## Additional Info

bors · 2023-08-07T23:42:48Z

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

## Issue Addressed Closes #3404 (mostly) ## Proposed Changes - Remove all uses of Warp's `and_then` (which backtracks) in favour of `then` (which doesn't). - Bump the priority of the `POST` method for `v2/blocks` to `P0`. Publishing a block needs to happen quickly. - Run the new SSZ POST endpoints on the beacon processor. I think this was missed in between merging #4462 and #4504/#4479. - Fix a minor issue in the validator registrations endpoint whereby an error from spawning the task on the beacon processor would be dropped. ## Additional Info I've tested this manually and can confirm that we no longer get the dreaded `Unsupported endpoint version` errors for queries like: ``` $ curl -X POST -H "Content-Type: application/json" --data @block.json "http://localhost:5052/eth/v2/beacon/blocks" | jq { "code": 400, "message": "BAD_REQUEST: WeakSubjectivityConflict", "stacktraces": [] } ``` ``` $ curl -X POST -H "Content-Type: application/octet-stream" --data @block.json "http://localhost:5052/eth/v2/beacon/blocks" | jq { "code": 400, "message": "BAD_REQUEST: invalid SSZ: OffsetOutOfBounds(572530811)", "stacktraces": [] } ``` ``` $ curl "http://localhost:5052/eth/v2/validator/blocks/7067595" {"code":400,"message":"BAD_REQUEST: invalid query: Invalid query string","stacktraces":[]} ``` However, I can still trigger it by leaving off the `Content-Type`. We can re-test this aspect with #4575.

…1 & v2) (sigp#4504) add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2)

Closes sigp#3404 (mostly) - Remove all uses of Warp's `and_then` (which backtracks) in favour of `then` (which doesn't). - Bump the priority of the `POST` method for `v2/blocks` to `P0`. Publishing a block needs to happen quickly. - Run the new SSZ POST endpoints on the beacon processor. I think this was missed in between merging sigp#4462 and sigp#4504/sigp#4479. - Fix a minor issue in the validator registrations endpoint whereby an error from spawning the task on the beacon processor would be dropped. I've tested this manually and can confirm that we no longer get the dreaded `Unsupported endpoint version` errors for queries like: ``` $ curl -X POST -H "Content-Type: application/json" --data @block.json "http://localhost:5052/eth/v2/beacon/blocks" | jq { "code": 400, "message": "BAD_REQUEST: WeakSubjectivityConflict", "stacktraces": [] } ``` ``` $ curl -X POST -H "Content-Type: application/octet-stream" --data @block.json "http://localhost:5052/eth/v2/beacon/blocks" | jq { "code": 400, "message": "BAD_REQUEST: invalid SSZ: OffsetOutOfBounds(572530811)", "stacktraces": [] } ``` ``` $ curl "http://localhost:5052/eth/v2/validator/blocks/7067595" {"code":400,"message":"BAD_REQUEST: invalid query: Invalid query string","stacktraces":[]} ``` However, I can still trigger it by leaving off the `Content-Type`. We can re-test this aspect with sigp#4575.

…1 & v2) (sigp#4504) add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2)

Closes sigp#3404 (mostly) - Remove all uses of Warp's `and_then` (which backtracks) in favour of `then` (which doesn't). - Bump the priority of the `POST` method for `v2/blocks` to `P0`. Publishing a block needs to happen quickly. - Run the new SSZ POST endpoints on the beacon processor. I think this was missed in between merging sigp#4462 and sigp#4504/sigp#4479. - Fix a minor issue in the validator registrations endpoint whereby an error from spawning the task on the beacon processor would be dropped. I've tested this manually and can confirm that we no longer get the dreaded `Unsupported endpoint version` errors for queries like: ``` $ curl -X POST -H "Content-Type: application/json" --data @block.json "http://localhost:5052/eth/v2/beacon/blocks" | jq { "code": 400, "message": "BAD_REQUEST: WeakSubjectivityConflict", "stacktraces": [] } ``` ``` $ curl -X POST -H "Content-Type: application/octet-stream" --data @block.json "http://localhost:5052/eth/v2/beacon/blocks" | jq { "code": 400, "message": "BAD_REQUEST: invalid SSZ: OffsetOutOfBounds(572530811)", "stacktraces": [] } ``` ``` $ curl "http://localhost:5052/eth/v2/validator/blocks/7067595" {"code":400,"message":"BAD_REQUEST: invalid query: Invalid query string","stacktraces":[]} ``` However, I can still trigger it by leaving off the `Content-Type`. We can re-test this aspect with sigp#4575.

eserilev added 3 commits July 12, 2023 22:48

add blinded beacon block ssz support v1

945ced6

blinded block ssz support

ff93f66

Merge branch 'unstable' of https://github.com/sigp/lighthouse into bl…

7fa96f5

…inded-beacon-block-ssz

eserilev marked this pull request as ready for review July 13, 2023 22:17

jimmygchen added ready-for-review The code is ready for review HTTP-API labels Jul 13, 2023

paulhauner reviewed Jul 20, 2023

View reviewed changes

paulhauner added the blocked label Jul 20, 2023

eserilev added 3 commits August 1, 2023 09:14

merge unstable

02482d1

merge unstable

db85c46

revert

1f655fa

paulhauner approved these changes Aug 2, 2023

View reviewed changes

paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review blocked labels Aug 2, 2023

bors bot changed the title ~~Support SSZ request body for POST /beacon/blinded_blocks endpoints (v1 & v2)~~ [Merged by Bors] - Support SSZ request body for POST /beacon/blinded_blocks endpoints (v1 & v2) Aug 7, 2023

bors bot closed this Aug 7, 2023

jimmygchen mentioned this pull request Aug 9, 2023

Add ssz content type for /eth/v1/beacon/blinded_blocks endpoint #4262

Closed

michaelsproul mentioned this pull request Aug 10, 2023

[Merged by Bors] - Improve HTTP API error messages + tweaks #4595

Closed

chong-he added the v4.4.1 ETA August 2023 label Sep 14, 2023

Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024

Support SSZ request body for POST /beacon/blinded_blocks endpoints (v…

8cbe3fa

…1 & v2) (sigp#4504) add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2)

Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024

Support SSZ request body for POST /beacon/blinded_blocks endpoints (v…

273760f

…1 & v2) (sigp#4504) add SSZ support in request body for POST /beacon/blinded_blocks endpoints (v1 & v2)

		StatusCode::INTERNAL_SERVER_ERROR,
		eth2::StatusCode::INTERNAL_SERVER_ERROR,

Conversation

eserilev commented Jul 13, 2023

Issue Addressed

Proposed Changes

Additional Info

Uh oh!

paulhauner commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulhauner left a comment

Choose a reason for hiding this comment

Uh oh!

paulhauner Jul 20, 2023

Choose a reason for hiding this comment

Uh oh!

paulhauner Jul 20, 2023

Choose a reason for hiding this comment

Uh oh!

paulhauner commented Jul 20, 2023

Uh oh!

eserilev commented Aug 1, 2023

Uh oh!

paulhauner left a comment

Choose a reason for hiding this comment

Uh oh!

paulhauner commented Aug 2, 2023

Uh oh!

bors bot commented Aug 2, 2023

Uh oh!

bors bot commented Aug 2, 2023

Uh oh!

divagant-martian commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulhauner commented Aug 3, 2023

Uh oh!

bors bot commented Aug 3, 2023

Uh oh!

eserilev commented Aug 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulhauner commented Aug 6, 2023

Uh oh!

paulhauner commented Aug 7, 2023

Uh oh!

bors bot commented Aug 7, 2023

Uh oh!

bors bot commented Aug 7, 2023

Uh oh!

paulhauner commented Aug 7, 2023

Uh oh!

bors bot commented Aug 7, 2023

Uh oh!

paulhauner commented Aug 7, 2023

Uh oh!

bors bot commented Aug 7, 2023

Uh oh!

paulhauner commented Aug 7, 2023

Uh oh!

bors bot commented Aug 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

paulhauner commented Jul 20, 2023 •

edited

Loading

divagant-martian commented Aug 3, 2023 •

edited

Loading

eserilev commented Aug 4, 2023 •

edited

Loading