[Merged by Bors] - Remove Router/Processor Code#4002
Closed
danielrachi1 wants to merge 7 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Remove Router/Processor Code#4002danielrachi1 wants to merge 7 commits intosigp:unstablefrom
danielrachi1 wants to merge 7 commits intosigp:unstablefrom
Conversation
Contributor
|
Ignore the conflicts for now, they should be resolved after #4019 |
divagant-martian
suggested changes
Feb 22, 2023
Contributor
There was a problem hiding this comment.
This is looking good! I left some suggestions regarding the merge of the structs, but most comments are simply docs and comment updates that we can take advantage and tackle right now. Also, as per previous comment please ignore the conflicts to unstable for now
divagant-martian
approved these changes
Feb 27, 2023
Contributor
divagant-martian
left a comment
There was a problem hiding this comment.
Yeah this is a good and needed change. I missed a little typo, otherwise looks perfect. Thanks for the help!
Contributor
|
@danielrachi #4019 has been merged so now conflicts should be more manageable, could you please merge unstable into your branch to handle those? |
divagant-martian
approved these changes
Mar 6, 2023
Contributor
divagant-martian
left a comment
There was a problem hiding this comment.
LGTM. I still want to run this on our infra before merging
pawanjay176
approved these changes
Mar 10, 2023
Member
pawanjay176
left a comment
There was a problem hiding this comment.
Looks good. Thanks for this :)
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
## Issue Addressed #3938 ## Proposed Changes - `network::Processor` is deleted and all it's logic is moved to `network::Router`. - The `network::Router` module is moved to a single file. - The following functions are deleted: `on_disconnect` `send_status` `on_status_response` `on_blocks_by_root_request` `on_lightclient_bootstrap` `on_blocks_by_range_request` `on_block_gossip` `on_unaggregated_attestation_gossip` `on_aggregated_attestation_gossip` `on_voluntary_exit_gossip` `on_proposer_slashing_gossip` `on_attester_slashing_gossip` `on_sync_committee_signature_gossip` `on_sync_committee_contribution_gossip` `on_light_client_finality_update_gossip` `on_light_client_optimistic_update_gossip`. This deletions are possible because the updated `Router` allows the underlying methods to be called directly.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
## Issue Addressed #3938 ## Proposed Changes - `network::Processor` is deleted and all it's logic is moved to `network::Router`. - The `network::Router` module is moved to a single file. - The following functions are deleted: `on_disconnect` `send_status` `on_status_response` `on_blocks_by_root_request` `on_lightclient_bootstrap` `on_blocks_by_range_request` `on_block_gossip` `on_unaggregated_attestation_gossip` `on_aggregated_attestation_gossip` `on_voluntary_exit_gossip` `on_proposer_slashing_gossip` `on_attester_slashing_gossip` `on_sync_committee_signature_gossip` `on_sync_committee_contribution_gossip` `on_light_client_finality_update_gossip` `on_light_client_optimistic_update_gossip`. This deletions are possible because the updated `Router` allows the underlying methods to be called directly.
|
Build failed: |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
## Issue Addressed #3938 ## Proposed Changes - `network::Processor` is deleted and all it's logic is moved to `network::Router`. - The `network::Router` module is moved to a single file. - The following functions are deleted: `on_disconnect` `send_status` `on_status_response` `on_blocks_by_root_request` `on_lightclient_bootstrap` `on_blocks_by_range_request` `on_block_gossip` `on_unaggregated_attestation_gossip` `on_aggregated_attestation_gossip` `on_voluntary_exit_gossip` `on_proposer_slashing_gossip` `on_attester_slashing_gossip` `on_sync_committee_signature_gossip` `on_sync_committee_contribution_gossip` `on_light_client_finality_update_gossip` `on_light_client_optimistic_update_gossip`. This deletions are possible because the updated `Router` allows the underlying methods to be called directly.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
- `network::Processor` is deleted and all it's logic is moved to `network::Router`. - The `network::Router` module is moved to a single file. - The following functions are deleted: `on_disconnect` `send_status` `on_status_response` `on_blocks_by_root_request` `on_lightclient_bootstrap` `on_blocks_by_range_request` `on_block_gossip` `on_unaggregated_attestation_gossip` `on_aggregated_attestation_gossip` `on_voluntary_exit_gossip` `on_proposer_slashing_gossip` `on_attester_slashing_gossip` `on_sync_committee_signature_gossip` `on_sync_committee_contribution_gossip` `on_light_client_finality_update_gossip` `on_light_client_optimistic_update_gossip`. This deletions are possible because the updated `Router` allows the underlying methods to be called directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#3938
Proposed Changes
network::Processoris deleted and all it's logic is moved tonetwork::Router.network::Routermodule is moved to a single file.on_disconnectsend_statuson_status_responseon_blocks_by_root_requeston_lightclient_bootstrapon_blocks_by_range_requeston_block_gossipon_unaggregated_attestation_gossipon_aggregated_attestation_gossipon_voluntary_exit_gossipon_proposer_slashing_gossipon_attester_slashing_gossipon_sync_committee_signature_gossipon_sync_committee_contribution_gossipon_light_client_finality_update_gossipon_light_client_optimistic_update_gossip. This deletions are possible because the updatedRouterallows the underlying methods to be called directly.