Skip to content

[Merged by Bors] - Release v3.4.0#3862

Closed
paulhauner wants to merge 1 commit intounstablefrom
cut-v3.4.0
Closed

[Merged by Bors] - Release v3.4.0#3862
paulhauner wants to merge 1 commit intounstablefrom
cut-v3.4.0

Conversation

@paulhauner
Copy link
Member

@paulhauner paulhauner commented Jan 9, 2023 •
edited by michaelsproul
Loading

@paulhauner paulhauner added the work-in-progress PR is a work-in-progress label Jan 9, 2023
@paulhauner paulhauner changed the title Cut v3.4.0 Release v3.4.0 Jan 9, 2023
@paulhauner paulhauner changed the base branch from unstable to stable January 9, 2023 21:59
@paulhauner paulhauner changed the base branch from stable to unstable January 9, 2023 21:59
@paulhauner
Copy link
Member Author

paulhauner commented Jan 10, 2023

Force pushed to include #3866

@paulhauner paulhauner changed the base branch from unstable to stable January 10, 2023 01:53
@paulhauner paulhauner changed the base branch from stable to unstable January 10, 2023 01:53
@michaelsproul michaelsproul marked this pull request as ready for review January 11, 2023 00:12
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed blocked work-in-progress PR is a work-in-progress labels Jan 11, 2023
michaelsproul
michaelsproul approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do it!

@paulhauner
Copy link
Member Author

paulhauner commented Jan 11, 2023

🎉 I'll merge this now and push the v3.4.0 flag so CI can start running. It's most likely that we'll merge to stable and publish the release in ~24hrs. This will give CI some time to run and for us to troubleshoot any issues.

Users should wait until stable is updated and the release has been published before updating, just in case we find anything during the release process.

@paulhauner
Copy link
Member Author

paulhauner commented Jan 11, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jan 11, 2023
@paulhauner
Release v3.4.0 (#3862)
ad85f56 
## Issue Addressed

NA

## Proposed Changes

Bump versions

## Additional Info

- [x] ~~Blocked on #3728, #3801~~
- [x] ~~Blocked on #3866~~
- [x] Requires additional testing
@bors
Copy link

bors bot commented Jan 11, 2023

Build failed:

@michaelsproul
Copy link
Member

michaelsproul commented Jan 11, 2023

grr Github API failure

bors retry

bors bot pushed a commit that referenced this pull request Jan 11, 2023
@paulhauner
Release v3.4.0 (#3862)
ad1aea4 
## Issue Addressed

NA

## Proposed Changes

Bump versions

## Additional Info

- [x] ~~Blocked on #3728, #3801~~
- [x] ~~Blocked on #3866~~
- [x] Requires additional testing
@bors
Copy link

bors bot commented Jan 11, 2023

Build failed:

  • release-tests-windows

@paulhauner
Copy link
Member Author

paulhauner commented Jan 11, 2023

Windows test failed due to the non-deterministic test_same_subnet_unsubscription test.

bors retry

bors bot pushed a commit that referenced this pull request Jan 11, 2023
@paulhauner
Release v3.4.0 (#3862)
46a67c3 
## Issue Addressed

NA

## Proposed Changes

Bump versions

## Additional Info

- [x] ~~Blocked on #3728, #3801~~
- [x] ~~Blocked on #3866~~
- [x] Requires additional testing
@bors
Copy link

bors bot commented Jan 11, 2023

Build failed:

@michaelsproul
Copy link
Member

michaelsproul commented Jan 11, 2023

Cargo OOMed

bors retry

bors bot pushed a commit that referenced this pull request Jan 11, 2023
@paulhauner
Release v3.4.0 (#3862)
38514c0 
## Issue Addressed

NA

## Proposed Changes

Bump versions

## Additional Info

- [x] ~~Blocked on #3728, #3801~~
- [x] ~~Blocked on #3866~~
- [x] Requires additional testing
@bors
Copy link

bors bot commented Jan 11, 2023

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Release v3.4.0 [Merged by Bors] - Release v3.4.0 Jan 11, 2023
@bors bors bot closed this Jan 11, 2023
@paulhauner paulhauner deleted the cut-v3.4.0 branch April 25, 2023 23:53
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@paulhauner @Woodpile37
Release v3.4.0 (sigp#3862)
d52f244 
## Issue Addressed

NA

## Proposed Changes

Bump versions

## Additional Info

- [x] ~~Blocked on sigp#3728, sigp#3801~~
- [x] ~~Blocked on sigp#3866~~
- [x] Requires additional testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees

No one assigned

Labels

ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulhauner @michaelsproul