Skip to content

Merge with unstable and fix clippy#3842

Merged
michaelsproul merged 5 commits intosigp:capellafrom
ethDreamer:capella
Dec 28, 2022
Merged

Merge with unstable and fix clippy#3842
michaelsproul merged 5 commits intosigp:capellafrom
ethDreamer:capella

Conversation

@ethDreamer
Copy link
Member

Clippy was complaining a lot.. I went through and fixed the issues before realizing that diva already did this in unstable 😩

divagant-martian and others added 5 commits December 16, 2022 04:04
## Issue Addressed
Fixes the new clippy lints for rust 1.66

## Proposed Changes

Most of the changes come from:
- [unnecessary_cast](https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast)
- [iter_kv_map](https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map)
- [needless_borrow](https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow)

## Additional Info

na
The notion of "phases" doesn't exist anymore in the Ethereum roadmap. Also fix dead link to roadmap.

Co-authored-by: Michael Sproul <micsproul@gmail.com>
## Issue Addressed

Closes sigp#3812
Closes sigp#3750
Closes sigp#3705
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaelsproul michaelsproul merged commit 222a514 into sigp:capella Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants