[Merged by Bors] - Register blocks in validator monitor#3635
Closed
tthebst wants to merge 5 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Register blocks in validator monitor#3635tthebst wants to merge 5 commits intosigp:unstablefrom
tthebst wants to merge 5 commits intosigp:unstablefrom
Conversation
michaelsproul
approved these changes
Nov 9, 2022
Member
michaelsproul
left a comment
There was a problem hiding this comment.
Happy to merge this too
Just applying a no-op commit in order to re-trigger the branch check
Member
|
bors r+ |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Member
|
bors r- |
Member
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
## Issue Addressed Closes #3460 ## Proposed Changes `blocks` and `block_min_delay` are never updated in the epoch summary Co-authored-by: Michael Sproul <micsproul@gmail.com>
|
Pull request successfully merged into unstable. Build succeeded:
|
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
## Issue Addressed Closes sigp#3460 ## Proposed Changes `blocks` and `block_min_delay` are never updated in the epoch summary Co-authored-by: Michael Sproul <micsproul@gmail.com>
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed Closes sigp#3460 ## Proposed Changes `blocks` and `block_min_delay` are never updated in the epoch summary Co-authored-by: Michael Sproul <micsproul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #3460
Proposed Changes
blocksandblock_min_delayare never updated in the epoch summary