[Merged by Bors] - Sync committee sign bn fallback#3624
Closed
tthebst wants to merge 8 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Sync committee sign bn fallback#3624tthebst wants to merge 8 commits intosigp:unstablefrom
tthebst wants to merge 8 commits intosigp:unstablefrom
Conversation
michaelsproul
approved these changes
Nov 9, 2022
Member
michaelsproul
left a comment
There was a problem hiding this comment.
Nice!
Sorry it took so long for us to review, will merge this with the typo corrected.
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
## Issue Addressed Closes #3612 ## Proposed Changes - Iterates through BNs until it finds a non-optimistic head. A slight change in error behavior: - Previously: `spawn_contribution_tasks` did not return an error for a non-optimistic block head. It returned `Ok(())` logged a warning. - Now: `spawn_contribution_tasks` returns an error if it cannot find a non-optimistic block head. The caller of `spawn_contribution_tasks` then logs the error as a critical error. Co-authored-by: Michael Sproul <micsproul@gmail.com>
Member
|
bors r- |
|
Canceled. |
Member
|
noticed that the simulator is failing semi-consistently with errors about sync aggregates. it may not be related to this PR but I think we should look into it before merging |
michaelsproul
approved these changes
Nov 13, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2022
## Issue Addressed Closes #3612 ## Proposed Changes - Iterates through BNs until it finds a non-optimistic head. A slight change in error behavior: - Previously: `spawn_contribution_tasks` did not return an error for a non-optimistic block head. It returned `Ok(())` logged a warning. - Now: `spawn_contribution_tasks` returns an error if it cannot find a non-optimistic block head. The caller of `spawn_contribution_tasks` then logs the error as a critical error. Co-authored-by: Michael Sproul <micsproul@gmail.com>
|
Pull request successfully merged into unstable. Build succeeded:
|
Contributor
Author
|
The if statement below that checked if |
Member
|
It'll be a breaking change for old versions of Lighthouse that don't have that flag, but should only affect Gnosis chain (which is still unmerged). |
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
## Issue Addressed Closes sigp#3612 ## Proposed Changes - Iterates through BNs until it finds a non-optimistic head. A slight change in error behavior: - Previously: `spawn_contribution_tasks` did not return an error for a non-optimistic block head. It returned `Ok(())` logged a warning. - Now: `spawn_contribution_tasks` returns an error if it cannot find a non-optimistic block head. The caller of `spawn_contribution_tasks` then logs the error as a critical error. Co-authored-by: Michael Sproul <micsproul@gmail.com>
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed Closes sigp#3612 ## Proposed Changes - Iterates through BNs until it finds a non-optimistic head. A slight change in error behavior: - Previously: `spawn_contribution_tasks` did not return an error for a non-optimistic block head. It returned `Ok(())` logged a warning. - Now: `spawn_contribution_tasks` returns an error if it cannot find a non-optimistic block head. The caller of `spawn_contribution_tasks` then logs the error as a critical error. Co-authored-by: Michael Sproul <micsproul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #3612
Proposed Changes
A slight change in error behavior:
spawn_contribution_tasksdid not return an error for a non-optimistic block head. It returnedOk(())logged a warning.spawn_contribution_tasksreturns an error if it cannot find a non-optimistic block head. The caller ofspawn_contribution_tasksthen logs the error as a critical error.