[Merged by Bors] - Return readonly: false for local keystores#3490
Closed
paulhauner wants to merge 2 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Return readonly: false for local keystores#3490paulhauner wants to merge 2 commits intosigp:unstablefrom
readonly: false for local keystores#3490paulhauner wants to merge 2 commits intosigp:unstablefrom
Conversation
Member
|
Looks like there are a couple of tests that need updating |
Member
Author
|
All tests passing, the fix was easy: 1c804a9 |
michaelsproul
approved these changes
Aug 24, 2022
Member
michaelsproul
left a comment
There was a problem hiding this comment.
Nice, let's batch this with the other ready-for-bors?
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
## Issue Addressed NA ## Proposed Changes Indicate that local keystores are `readonly: Some(false)` rather than `None` via the `/eth/v1/keystores` method on the VC API. I'll mark this as backwards-incompat so we remember to mention it in the release notes. There aren't any type-level incompatibilities here, just a change in how Lighthouse responds to responses. ## Additional Info - Blocked on #3464
readonly: false for local keystoresreadonly: false for local keystores
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed NA ## Proposed Changes Indicate that local keystores are `readonly: Some(false)` rather than `None` via the `/eth/v1/keystores` method on the VC API. I'll mark this as backwards-incompat so we remember to mention it in the release notes. There aren't any type-level incompatibilities here, just a change in how Lighthouse responds to responses. ## Additional Info - Blocked on sigp#3464
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Indicate that local keystores are
readonly: Some(false)rather thanNonevia the/eth/v1/keystoresmethod on the VC API.I'll mark this as backwards-incompat so we remember to mention it in the release notes. There aren't any type-level incompatibilities here, just a change in how Lighthouse responds to responses.
Additional Info