[Merged by Bors] - Enable block_lookup_failed EF test#3489
Closed
paulhauner wants to merge 1 commit intosigp:unstablefrom
Closed
[Merged by Bors] - Enable block_lookup_failed EF test#3489paulhauner wants to merge 1 commit intosigp:unstablefrom
block_lookup_failed EF test#3489paulhauner wants to merge 1 commit intosigp:unstablefrom
Conversation
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
## Issue Addressed Resolves #3448 ## Proposed Changes Removes a known failure that wasn't actually a known failure. The tests declare this block invalid and we refuse to import it due to `ExecutionPayloadError(UnverifiedNonOptimisticCandidate)`. This is correct since there is only one "eth1" block included in this test and two are required to trigger the merge (pre- and post-TTD blocks). It is slot 1 (tick = 12s) when this block is imported so the import must be prevented by `SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY`. I'm not sure where I got the idea in #3448 that this test needed retrospective checking, that seems like a false assumption in hindsight. ## Additional Info - Blocked on #3464
block_lookup_failed EF testblock_lookup_failed EF test
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed Resolves sigp#3448 ## Proposed Changes Removes a known failure that wasn't actually a known failure. The tests declare this block invalid and we refuse to import it due to `ExecutionPayloadError(UnverifiedNonOptimisticCandidate)`. This is correct since there is only one "eth1" block included in this test and two are required to trigger the merge (pre- and post-TTD blocks). It is slot 1 (tick = 12s) when this block is imported so the import must be prevented by `SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY`. I'm not sure where I got the idea in sigp#3448 that this test needed retrospective checking, that seems like a false assumption in hindsight. ## Additional Info - Blocked on sigp#3464
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #3448
Proposed Changes
Removes a known failure that wasn't actually a known failure. The tests declare this block invalid and we refuse to import it due to
ExecutionPayloadError(UnverifiedNonOptimisticCandidate).This is correct since there is only one "eth1" block included in this test and two are required to trigger the merge (pre- and post-TTD blocks). It is slot 1 (tick = 12s) when this block is imported so the import must be prevented by
SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY.I'm not sure where I got the idea in #3448 that this test needed retrospective checking, that seems like a false assumption in hindsight.
Additional Info