[Merged by Bors] - Increase merge-readiness lookhead#3463
Closed
paulhauner wants to merge 5 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Increase merge-readiness lookhead#3463paulhauner wants to merge 5 commits intosigp:unstablefrom
paulhauner wants to merge 5 commits intosigp:unstablefrom
Conversation
paulhauner
added a commit
that referenced
this pull request
Aug 12, 2022
commit d2d5fa0 Author: Paul Hauner <paul@paulhauner.com> Date: Fri Aug 12 10:38:52 2022 +1000 Always log readiness if an EL is configured commit 4d0e819 Author: Paul Hauner <paul@paulhauner.com> Date: Fri Aug 12 10:29:22 2022 +1000 Go back to 2 weeks commit 1e4eade Author: Paul Hauner <paul@paulhauner.com> Date: Fri Aug 12 10:14:03 2022 +1000 Set to 2.5 weeks commit cc84894 Author: Paul Hauner <paul@paulhauner.com> Date: Fri Aug 12 10:12:41 2022 +1000 Increase merge readiness lookahead to 3 weeks
d2d5fa0 to
8e1f7bf
Compare
pawanjay176
reviewed
Aug 13, 2022
Member
pawanjay176
left a comment
There was a problem hiding this comment.
If we release this before EL clients make their releases and users run with an EL, then they will still get exchange_configuration errors right? .Maybe we can add an additional line in the notifier log for exchange configuration errors saying "update your EL/CL"?
Member
Author
Good idea! Added in 64adce8. |
Member
Author
|
Pentasquerge! 🚀 🚀 🚀 🚀 🚀 bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 15, 2022
## Issue Addressed
NA
## Proposed Changes
Start issuing merge-readiness logs 2 weeks before the Bellatrix fork epoch. Additionally, if the Bellatrix epoch is specified and the use has configured an EL, always log merge readiness logs, this should benefit pro-active users.
### Lookahead Reasoning
- Bellatrix fork is:
- epoch 144896
- slot 4636672
- Unix timestamp: `1606824023 + (4636672 * 12) = 1662464087`
- GMT: Tue Sep 06 2022 11:34:47 GMT+0000
- Warning start time is:
- Unix timestamp: `1662464087 - 604800 * 2 = 1661254487`
- GMT: Tue Aug 23 2022 11:34:47 GMT+0000
The [current expectation](https://discord.com/channels/595666850260713488/745077610685661265/1007445305198911569) is that EL and CL clients will releases out by Aug 22nd at the latest, then an EF announcement will go out on the 23rd. If all goes well, LH will start alerting users about merge-readiness just after the announcement.
## Additional Info
NA
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed
NA
## Proposed Changes
Start issuing merge-readiness logs 2 weeks before the Bellatrix fork epoch. Additionally, if the Bellatrix epoch is specified and the use has configured an EL, always log merge readiness logs, this should benefit pro-active users.
### Lookahead Reasoning
- Bellatrix fork is:
- epoch 144896
- slot 4636672
- Unix timestamp: `1606824023 + (4636672 * 12) = 1662464087`
- GMT: Tue Sep 06 2022 11:34:47 GMT+0000
- Warning start time is:
- Unix timestamp: `1662464087 - 604800 * 2 = 1661254487`
- GMT: Tue Aug 23 2022 11:34:47 GMT+0000
The [current expectation](https://discord.com/channels/595666850260713488/745077610685661265/1007445305198911569) is that EL and CL clients will releases out by Aug 22nd at the latest, then an EF announcement will go out on the 23rd. If all goes well, LH will start alerting users about merge-readiness just after the announcement.
## Additional Info
NA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Start issuing merge-readiness logs 2 weeks before the Bellatrix fork epoch. Additionally, if the Bellatrix epoch is specified and the use has configured an EL, always log merge readiness logs, this should benefit pro-active users.
Lookahead Reasoning
1606824023 + (4636672 * 12) = 16624640871662464087 - 604800 * 2 = 1661254487The current expectation is that EL and CL clients will releases out by Aug 22nd at the latest, then an EF announcement will go out on the 23rd. If all goes well, LH will start alerting users about merge-readiness just after the announcement.
Additional Info
NA