[Merged by Bors] - do not count sync batch attempts when peer is not at fault#3245
Closed
divagant-martian wants to merge 2 commits intosigp:unstablefrom
Closed
[Merged by Bors] - do not count sync batch attempts when peer is not at fault#3245divagant-martian wants to merge 2 commits intosigp:unstablefrom
divagant-martian wants to merge 2 commits intosigp:unstablefrom
Conversation
AgeManning
approved these changes
Jun 7, 2022
Member
AgeManning
left a comment
There was a problem hiding this comment.
Looks good to me.
Remove those chatty logs :)
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
## Issue Addressed currently we count a failed attempt for a syncing chain even if the peer is not at fault. This makes us do more work if the chain fails, and heavily penalize peers, when we can simply retry. Inspired by a proposal I made to #3094 ## Proposed Changes If a batch fails but the peer is not at fault, do not count the attempt Also removes some annoying logs ## Additional Info We still get a counter on ignored attempts.. just in case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
currently we count a failed attempt for a syncing chain even if the peer is not at fault. This makes us do more work if the chain fails, and heavily penalize peers, when we can simply retry. Inspired by a proposal I made to #3094
Proposed Changes
If a batch fails but the peer is not at fault, do not count the attempt
Also removes some annoying logs
Additional Info
We still get a counter on ignored attempts.. just in case