[Merged by Bors] - Create a local testnet by winksaville · Pull Request #2614 · sigp/lighthouse

winksaville · 2021-09-22T23:29:09Z

The testnet will be on the local computer and have 1 eth1 node,
4 beacon nodes, 1 validator with 20 vc's.

The testnet will be on the local computer and have 1 eth1 node, 4 beacon nodes, 1 validator with 20 vc's.

pawanjay176

This is awesome! thanks for doing this :)

Just a few small changes.

scripts/local_testnet/create_local_testnet.sh

The default is a the testnet will have 1 eth1 node, 4 beacon nodes, with 20 validators per node and 1 validator client using the 20 associated with beacon node 1.

winksaville · 2021-09-23T18:41:31Z

This is awesome! thanks for doing this :)

Just a few small changes.

@pawanjay176, I made your suggested changes and tweaked a few other things plus added some initial documentation, txs for the review!

pawanjay176

A few more nits.

Also, I think we should still keep the instructions to run the individual scripts (setup, bootnode, ganache, beacon, validator) after the instructions to run with start_local_testnet

scripts/local_testnet/README.md

pawanjay176 · 2021-09-24T14:22:11Z

scripts/local_testnet/README.md

-```bash
-./bootnode.sh
-```
+This script takes two options `-c VC_COUNT` and `-d DEBUG_LEVEL`.


Suggested change

This script takes two options `-c VC_COUNT` and `-d DEBUG_LEVEL`.

The `start_local_testnet.sh` script takes two options `-c VC_COUNT` and `-d DEBUG_LEVEL`.

Done, but changed -c to -v

scripts/local_testnet/README.md

pawanjay176 · 2021-09-24T14:25:13Z

scripts/local_testnet/beacon_node.sh

 exec lighthouse \
 	--debug-level $DEBUG_LEVEL \
 	bn \
+	--subscribe-all-subnets \


Not sure why this option was added. I don't think this should be present by default.

@michaelsproul suggested I do that as it was needed when only using one vc. I've made it option -s.

scripts/local_testnet/start_local_testnet.sh

pawanjay176 · 2021-09-24T14:32:53Z

scripts/local_testnet/vars.env

+# Number of seconds to delay to start genesis block.
+# If started by a script this can be 0, if starting by hand
+# use something like 180.
+GENESIS_DELAY=0


I think this should be >0 by default (60secs maybe?) as we usually also want to check genesis as well when running local testnets.

GENESIS_DELAY=0 appears to work and long values just forces the user to wait longer before "regular" work/output from BN's and VC's. I could make it an option to start_local_testnet.sh and make have it default to 0 or a small number if 0 is wrong. The simplest option is to leave it at the some minimum value, 0, and when a developer needs to "check genesis" they can change vars.env.

What would you like to do?

I'm happy with genesis delay 0, tweaking vars.env is always an option.

scripts/local_testnet/README.md

README.md - Added back the original manual creation docs - Some cleanup beacon_node.sh - Add command line Options so as to allow --subscribe-all-subnets to be controlled by caller - Handle positional parameters using $ORIND from getopts setup.sh -Rename NODE_COUNT to BN_COUNT start_local_testnet.sh - rename -c to -v for VC_COUNT - Clean up -h - Use VC_COUNT and BN_COUNT - Use bn as for loop variable

winksaville

@pawanjay176, I believe I've address all of your comments except setting GENESIS_DELAY to zero, see my comment.

On a similar note, in start_local_testnet.sh I've got 3 sleeping x function calls and this is very fragile, what would you suggest as an alternatives solution?

scripts/local_testnet/README.md

winksaville · 2021-09-24T18:16:18Z

scripts/local_testnet/README.md

-```bash
-./bootnode.sh
-```
+This script takes two options `-c VC_COUNT` and `-d DEBUG_LEVEL`.


Done, but changed -c to -v

scripts/local_testnet/README.md

winksaville · 2021-09-24T18:25:57Z

scripts/local_testnet/beacon_node.sh

 exec lighthouse \
 	--debug-level $DEBUG_LEVEL \
 	bn \
+	--subscribe-all-subnets \


@michaelsproul suggested I do that as it was needed when only using one vc. I've made it option -s.

scripts/local_testnet/start_local_testnet.sh

winksaville · 2021-09-24T19:35:36Z

scripts/local_testnet/vars.env

+# Number of seconds to delay to start genesis block.
+# If started by a script this can be 0, if starting by hand
+# use something like 180.
+GENESIS_DELAY=0


GENESIS_DELAY=0 appears to work and long values just forces the user to wait longer before "regular" work/output from BN's and VC's. I could make it an option to start_local_testnet.sh and make have it default to 0 or a small number if 0 is wrong. The simplest option is to leave it at the some minimum value, 0, and when a developer needs to "check genesis" they can change vars.env.

What would you like to do?

winksaville · 2021-09-29T01:48:19Z

@pawanjay176 @michaelsproul do either of you or anyone else have any other suggestions for changes?

One outstanding issue is what to do about GENESIS_DELAY, see a small discussion starts here.

michaelsproul

Looks good!

Tested it locally and I'm happy with it. Happy to merge once typos are corrected

scripts/local_testnet/README.md

scripts/local_testnet/beacon_node.sh

michaelsproul · 2021-09-30T00:24:52Z

scripts/local_testnet/vars.env

+# Number of seconds to delay to start genesis block.
+# If started by a script this can be 0, if starting by hand
+# use something like 180.
+GENESIS_DELAY=0


I'm happy with genesis delay 0, tweaking vars.env is always an option.

michaelsproul

Awesome, let's merge!

michaelsproul · 2021-09-30T03:19:38Z

bors r+

The testnet will be on the local computer and have 1 eth1 node, 4 beacon nodes, 1 validator with 20 vc's.

michaelsproul · 2021-09-30T04:29:40Z

The doppelganger protection tests are failing due to the BN_COUNT rename. We can merge once that's fixed, but I'm going to drop this PR from the current batch (and the v2.0.0-rc.0)

michaelsproul · 2021-09-30T04:29:47Z

bors r-

bors · 2021-09-30T04:29:48Z

Canceled.

winksaville · 2021-09-30T05:27:50Z

bors r-
Ok, I'll look at it tomorrow.

Made `tests/vars.env` identical to `local_testnet/vars.env` except for adding `VC_ARGS= --enable-doppelganger-protection ". This was needed because of the renaming of NODE_COUNT to BN_COUNT.

winksaville · 2021-09-30T18:10:19Z

The doppelganger protection tests are failing due to the BN_COUNT rename. We can merge once that's fixed, but I'm going to drop this PR from the current batch (and the v2.0.0-rc.0)

Fixed!

michaelsproul

Great. Will merge this after v2.0.0-rc.0 merges.

michaelsproul · 2021-10-01T06:32:24Z

bors r+

The testnet will be on the local computer and have 1 eth1 node, 4 beacon nodes, 1 validator with 20 vc's.

bors · 2021-10-01T08:24:38Z

Pull request successfully merged into unstable.

Build succeeded:

Create a local testnet

553499f

The testnet will be on the local computer and have 1 eth1 node, 4 beacon nodes, 1 validator with 20 vc's.

winksaville marked this pull request as draft September 22, 2021 23:29

pawanjay176 requested changes Sep 23, 2021

View reviewed changes

scripts/local_testnet/create_local_testnet.sh Outdated Show resolved Hide resolved

scripts/local_testnet/create_local_testnet.sh Outdated Show resolved Hide resolved

Start a local testnet

72c0eda

The default is a the testnet will have 1 eth1 node, 4 beacon nodes, with 20 validators per node and 1 validator client using the 20 associated with beacon node 1.

winksaville marked this pull request as ready for review September 23, 2021 21:05

winksaville requested a review from pawanjay176 September 24, 2021 00:50

pawanjay176 requested changes Sep 24, 2021

View reviewed changes

winksaville commented Sep 24, 2021

View reviewed changes

michaelsproul requested changes Sep 30, 2021

View reviewed changes

michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Sep 30, 2021

Incorporate review changes from Michael Sproul

81e466a

winksaville requested review from michaelsproul and pawanjay176 September 30, 2021 02:47

michaelsproul approved these changes Sep 30, 2021

View reviewed changes

michaelsproul added ready-for-merge This PR is ready to merge. v2.0.0 Altair on mainnet release (v2.0.0) and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 30, 2021

bors bot pushed a commit that referenced this pull request Sep 30, 2021

Create a local testnet (#2614)

27bcbc8

The testnet will be on the local computer and have 1 eth1 node, 4 beacon nodes, 1 validator with 20 vc's.

michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. v2.0.0 Altair on mainnet release (v2.0.0) labels Sep 30, 2021

Fix failing doppelganger_protection test

8bec831

Made `tests/vars.env` identical to `local_testnet/vars.env` except for adding `VC_ARGS= --enable-doppelganger-protection ". This was needed because of the renaming of NODE_COUNT to BN_COUNT.

winksaville mentioned this pull request Sep 30, 2021

/script/tests/doppelganger_protection.sh succeeded when it should have failed #2656

Open

winksaville requested a review from michaelsproul September 30, 2021 18:11

michaelsproul approved these changes Oct 1, 2021

View reviewed changes

michaelsproul added blocked ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. blocked labels Oct 1, 2021

bors bot pushed a commit that referenced this pull request Oct 1, 2021

Create a local testnet (#2614)

21d1af4

The testnet will be on the local computer and have 1 eth1 node, 4 beacon nodes, 1 validator with 20 vc's.

bors bot changed the title ~~Create a local testnet~~ [Merged by Bors] - Create a local testnet Oct 1, 2021

bors bot closed this Oct 1, 2021

	This script takes two options `-c VC_COUNT` and `-d DEBUG_LEVEL`.
	The `start_local_testnet.sh` script takes two options `-c VC_COUNT` and `-d DEBUG_LEVEL`.

Conversation

winksaville commented Sep 22, 2021

Uh oh!

pawanjay176 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

winksaville commented Sep 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pawanjay176 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

winksaville left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

winksaville commented Sep 29, 2021

Uh oh!

michaelsproul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaelsproul left a comment

Choose a reason for hiding this comment

Uh oh!

michaelsproul commented Sep 30, 2021

Uh oh!

michaelsproul commented Sep 30, 2021

Uh oh!

michaelsproul commented Sep 30, 2021

Uh oh!

bors bot commented Sep 30, 2021

Uh oh!

winksaville commented Sep 30, 2021

Uh oh!

winksaville commented Sep 30, 2021

Uh oh!

michaelsproul left a comment

Choose a reason for hiding this comment

Uh oh!

michaelsproul commented Oct 1, 2021

Uh oh!

bors bot commented Oct 1, 2021

Uh oh!

Reviewers

Assignees

winksaville commented Sep 23, 2021 •

edited

Loading