[Merged by Bors] - Remove rayon from rest_api#1562
Closed
paulhauner wants to merge 1 commit intomasterfrom
Closed
Conversation
michaelsproul
approved these changes
Aug 24, 2020
Member
michaelsproul
left a comment
There was a problem hiding this comment.
Amazing detective work, I don't envy you having to dig through all those backtraces 😩
I'm satisfied that this is a real issue, and I hope it's the only one causing us to deadlock 🤞
PS. I found rayon-rs/rayon#592 which seems relevant and might be interesting to link from the HackMD
Member
Author
|
Thanks @michaelsproul! I've added that link to the HackMD 👍 I've been running this for about 4 hours without observing a deadlock. I wouldn't say that's confirmation yet, but it's a positive sign. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2020
## Issue Addressed NA ## Proposed Changes Addresses a deadlock condition described here: https://hackmd.io/ijQlqOdqSGaWmIo6zMVV-A?view ## Additional Info NA
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Addresses a deadlock condition described here: https://hackmd.io/ijQlqOdqSGaWmIo6zMVV-A?view
Additional Info
NA