Merged
Conversation
… would cause an invalid index error due to password having greater length than scramble.
… would cause an invalid index error due to password having greater length than scramble.
normano
commented
Oct 24, 2019
| scramble1, | ||
| scramble2 | ||
| ); | ||
| return exports.calculateTokenFromPasswordSha(stage1, scramble1, scramble2); |
Contributor
Author
There was a problem hiding this comment.
I know I did not touch these, so I suppose there must be pre commit hooks to do some auto formatting.
Owner
There was a problem hiding this comment.
yes, there is prettier percommit hook
Owner
|
LGTM, happy to merge once CI finish |
vlasky
added a commit
to vlasky/mysql
that referenced
this pull request
Apr 16, 2021
…ail for passwords longer than 19 characters. Thanks to sidorares and normano for their guidance. Refer to: mysqljs#2233 (comment) sidorares/node-mysql2#1044 sidorares/node-mysql2#1045 Updated version to 2.18.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the password xor scramble length issue by using xorRotated (as specified by MySQL Engineering insider blog).
Issue: #1044