fix: wipe the first/last 1MiB in addition to wiping by signatures#12620
Merged
talos-bot merged 1 commit intosiderolabs:mainfrom Jan 20, 2026
Merged
fix: wipe the first/last 1MiB in addition to wiping by signatures#12620talos-bot merged 1 commit intosiderolabs:mainfrom
talos-bot merged 1 commit intosiderolabs:mainfrom
Conversation
Member
Author
|
Split from #12611 |
frezbo
reviewed
Jan 19, 2026
aa509d0 to
c37f7f1
Compare
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 20, 2026
Open the blockdevice in `O_EXCL` mode when wiping to ensure that we don't wipe a mounted device. This issue was discovered via siderolabs#12620, when we wipe a blockdevice which is still mounted ending up in a wrong state. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 20, 2026
Open the blockdevice in `O_EXCL` mode when wiping to ensure that we don't wipe a mounted device. This issue was discovered via siderolabs#12620, when we wipe a blockdevice which is still mounted ending up in a wrong state. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
c37f7f1 to
2f0c3ae
Compare
shanduur
approved these changes
Jan 20, 2026
I got a failure when dual-boot image refuses to format EPHEMERAL partition where `EFI` partition used to be (VFAT). So until we have a resolution, do this workaround. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
2f0c3ae to
3d13016
Compare
Member
Author
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 21, 2026
Open the blockdevice in `O_EXCL` mode when wiping to ensure that we don't wipe a mounted device. This issue was discovered via siderolabs#12620, when we wipe a blockdevice which is still mounted ending up in a wrong state. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit f7072c0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got a failure when dual-boot image refuses to format EPHEMERAL partition where
EFIpartition used to be (VFAT).So until we have a resolution, do this workaround.