[1.11 backport] fix: race between VolumeConfigController and UserVolumeConfigController#12141
Closed
laurazard wants to merge 1 commit intosiderolabs:release-1.11from
Closed
Conversation
afc67e3 to
526b83e
Compare
f3ca1e1 to
464532b
Compare
smira
reviewed
Nov 5, 2025
smira
approved these changes
Nov 5, 2025
37ed2dc to
b93dc0d
Compare
This commit just copy/paste merges the VolumeConfig and UserVolumeConfig controllers, which addresses the race between system volume and user volume config creation. Signed-off-by: Laura Brehm <laurabrehm@hey.com>
b93dc0d to
630c48e
Compare
Member
|
I'm going to cherry-pick this into #12140 |
Member
|
cherry-picked |
smira
added a commit
to smira/talos
that referenced
this pull request
Feb 19, 2026
This is a regression introduced in siderolabs#12122 and siderolabs#12141. Without this, only `kubelet` holds `/var/mnt`, so on kubelet restart, Talos tries to unmount it, cascading into unmount of all user volumes, which shouldn't be the case. Fixes siderolabs#12797 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Feb 19, 2026
This is a regression introduced in siderolabs#12122 and siderolabs#12141. Without this, only `kubelet` holds `/var/mnt`, so on kubelet restart, Talos tries to unmount it, cascading into unmount of all user volumes, which shouldn't be the case. Fixes siderolabs#12797 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Feb 19, 2026
This is a regression introduced in siderolabs#12122 and siderolabs#12141. Without this, only `kubelet` holds `/var/mnt`, so on kubelet restart, Talos tries to unmount it, cascading into unmount of all user volumes, which shouldn't be the case. Fixes siderolabs#12797 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Mar 6, 2026
This is a regression introduced in siderolabs#12122 and siderolabs#12141. Without this, only `kubelet` holds `/var/mnt`, so on kubelet restart, Talos tries to unmount it, cascading into unmount of all user volumes, which shouldn't be the case. Fixes siderolabs#12797 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit e5b0eb0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What? (description)
(crappy) Backport of #12122 (without the refactor – this is just a copy/paste merge of the controllers, which while worse-looking is hopefully safer than the bigger refactor).
Why? (reasoning)
Addresses the system/user volume config creation race – see #11992
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)