fix: allow probing disks smaller than max magic size#142
Merged
talos-bot merged 2 commits intosiderolabs:v2from Dec 24, 2025
Merged
fix: allow probing disks smaller than max magic size#142talos-bot merged 2 commits intosiderolabs:v2from
talos-bot merged 2 commits intosiderolabs:v2from
Conversation
At the moment, max magic size is 64k, which doesn't allow probing filesystems smaller than that size. Skip magics which are bigger than the probe size. Add a regression test. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Member
Author
frezbo
approved these changes
Dec 23, 2025
Update Go modules. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
b233529 to
ee8cbdd
Compare
Member
Author
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 24, 2025
Fixes siderolabs#12477 The PR in go-blockdevice: siderolabs/go-blockdevice#142 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
shanduur
pushed a commit
to shanduur/talos
that referenced
this pull request
Jan 2, 2026
Fixes siderolabs#12477 The PR in go-blockdevice: siderolabs/go-blockdevice#142 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit f09ae1e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, max magic size is 64k, which doesn't allow probing
filesystems smaller than that size.
Skip magics which are bigger than the probe size.
Add a regression test.