Skip to content

Rebel branch#10

Closed
rebx wants to merge 3051 commits intoshyouhei:trunkfrom
rebx:rebel_branch
Closed

Rebel branch#10
rebx wants to merge 3051 commits intoshyouhei:trunkfrom
rebx:rebel_branch

Conversation

@rebx
Copy link

@rebx rebx commented Apr 9, 2013

It seems like the parse method does not escape characters properly before split is invoked on the uri. It causes it to throw an InvalidURI error on URIs like

'http://foo:foo,<@foo.com:8080'

A test case has been added for the example uri at commit b280822

To address the situation, I have added a call to escape before the split is invoked.

I am not entirely sure this is the best way to fix this matter, so feel free to comment on the matter. Please reject the patch if it's not necessary/useless/irrelevant.

This may be similar to http://bugs.ruby-lang.org/issues/1466

matzbot and others added 30 commits July 26, 2010 00:51
@matzbot
* 2010-07-26
6ea7d67 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nurse
* configure.in: define BROKEN_CLOSE on FreeBSD.
afd65e3 
  This fixes build failure on MSVC. [ruby-core:31481]

* include/ruby/ruby.h, include/ruby/missing.h:
  use BROKEN_CLOSE for replacing close(2).

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* vm.c (rb_thread_mark): should mark iseq itself other than normal
85ac32e 
  iseq.  [ruby-dev:41880]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nurse
* configure.in: define BROKEN_CLOSE only on FreeBSD.
6e09367 
  This needs to merge to 1.9.2.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@unak
* include/ruby/missing.h: revert a part of r28727. config.h is expected
dde84bb 
  to include only once, before including defines.h.
  including it here breaks some macro definitions.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* configure.in (XCFLAGS): missing.h needs config.h.
18d70b4 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* configure.in (config.h): add include guard.
1411ae2 
* win32/Makefile.sub, bcc32/Makefile.sub (config.h): ditto.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28759 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@akr
* ext/pathname/pathname.c (path_taint): Pathname#taint translated from
f663226 
  pathname.rb.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* compile.c (rb_iseq_translate_threaded_code): removed duplicated code.
191f12b 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nurse
* class.c, compile.c, dir.c, file.c, iseq.c, parse.y, random.c:
b6b5bc2 
  clean unused-value warnings.

* cont.c, process.c, vm_exec.h: clean cast warnings.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@unak
* numeric.c (flo_cmp): typo.
590792f 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* defines.h, intern.h, missing.h, ruby.h, st.h, util.h: include
81ee977 
  config.h and defines.h for autoconf macros.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* lib/mkmf.rb (have_framework): added.
f2995a9 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* Makefile.in (MINIRUBY): get rid of appending spaces for each
b6208f9 
	  reconfigure.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28766 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@akr
* ext/pathname/pathname.c (path_taint): use rb_obj_taint.
bc70437 
  (path_untaint): Pathname#untaint translated from
  pathname.rb.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28767 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nurse
* cont.c: (RB_PAGE_SIZE): renamed from PAGE_SIZE. [ruby-dev:41870]
e10ea4d 
* cont.c: (RB_PAGE_MASK): renamed from PAGE_MASK.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@matzbot
* 2010-07-28
e2d1620 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28769 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@unak
* cont.c: typos.
708e3ae 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* missing/*.c: include missing.h
6dfae13 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@unak
* win32/Makefile.sub (config.h): VC6 or later have stddef.h.
f483548 
* include/ruby/missing.h: need to include stddef.h for size_t.

* include/ruby/missing.h: shouldn't declare as dllimport when building
  ruby itself (for Windows).


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28772 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* vm_core.h (rb_thread_check_trap_pending): hidden API for tcl/tk wra…
449952b 
…pper.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@akr
add a test.
2f23b76 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28775 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@akr
* ext/pathname/pathname.c (path_eq): Pathname#{==,===,eql?} translated
cb38c20 
  from pathname.rb.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nurse
* configure.in: not [freebsd] but [freebsd*] for AS_CASE.
e4d048c 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@matzbot
* 2010-07-29
8651a00 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* file.c (rb_file_s_basename): pass baselen to rmext.
dfbd7e8 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@nobu
* common.mk (EXT_SRCS): add ext/json/parser/parser.c.
0704576 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@akr
* ext/pathname/pathname.c (path_cmp): Pathname#<=> translated
c92e2d6 
  from pathname.rb.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@akr
class description document moved.
07cba3d 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28789 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@matzbot
* 2010-07-30
8ab28f7 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@28790 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@shyouhei shyouhei force-pushed the trunk branch 8 times, most recently from fc3d177 to 09d9941 Compare October 18, 2018 06:46
shyouhei added a commit that referenced this pull request Oct 18, 2018
@shyouhei
fix SEGV in rb_raw_obj_info()
d3d1a3a 
This funcion can be called from inside of rb_ast_new().
Should add appropriate case branches.

(lldb) run
Process 9135 launched: './miniruby' (x86_64)
Process 9135 stopped
* thread #1: tid = 0xdf36b, 0x00000001000ca4f9 miniruby`rb_raw_obj_info(buff="0x000000010205d158 [0    ] T_IMEMO", buff_size=256, obj=4328903000) + 2361 at gc.c:9617, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x00000001000ca4f9 miniruby`rb_raw_obj_info(buff="0x000000010205d158 [0    ] T_IMEMO", buff_size=256, obj=4328903000) + 2361 at gc.c:9617
   9614                 IMEMO_NAME(iseq);
   9615                 IMEMO_NAME(tmpbuf);
   9616 #undef IMEMO_NAME
-> 9617               default: UNREACHABLE;
   9618             }
   9619             snprintf(buff, buff_size, "%s %s", buff, imemo_name);
   9620
(lldb) bt
* thread #1: tid = 0xdf36b, 0x00000001000ca4f9 miniruby`rb_raw_obj_info(buff="0x000000010205d158 [0    ] T_IMEMO", buff_size=256, obj=4328903000) + 2361 at gc.c:9617, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
  * frame #0: 0x00000001000ca4f9 miniruby`rb_raw_obj_info(buff="0x000000010205d158 [0    ] T_IMEMO", buff_size=256, obj=4328903000) + 2361 at gc.c:9617
    frame #1: 0x00000001000c433f miniruby`obj_info(obj=4328903000) + 95 at gc.c:9671
    frame #2: 0x00000001000ce2ac miniruby`newobj_init(klass=4302478608, flags=36890, v1=0, v2=0, v3=0, wb_protected=1, objspace=0x0000000101800410, obj=4328903000) + 444 at gc.c:1882
    frame #3: 0x00000001000c0a49 miniruby`newobj_of(klass=4302478608, flags=36890, v1=0, v2=0, v3=0, wb_protected=1) + 217 at gc.c:1968
    frame #4: 0x00000001000c0bcb miniruby`rb_imemo_new(type=imemo_ast, v1=0, v2=0, v3=0, v0=4302478608) + 75 at gc.c:2017
    frame #5: 0x0000000100148f2a miniruby`rb_ast_new + 58 at node.c:1118
    frame #6: 0x000000010018d9e2 miniruby`yycompile(vparser=4328903720, p=0x0000000100729670, fname=4328903160, line=1) + 98 at parse.y:4925
    frame #7: 0x000000010018d66f miniruby`parser_compile_string(vparser=4328903720, fname=4328903160, s=4328904440, line=1) + 143 at parse.y:4995
    frame #8: 0x000000010018d768 miniruby`rb_parser_compile_string_path(vparser=4328903720, f=4328903160, s=4328904440, line=1) + 56 at parse.y:5015
    frame #9: 0x000000010018d71e miniruby`rb_parser_compile_string(vparser=4328903720, f="-e", s=4328904440, line=1) + 62 at parse.y:5008
    frame #10: 0x00000001002130d5 miniruby`process_options(argc=0, argv=0x00007fff5fbfdc08, opt=0x00007fff5fbfd9e8) + 3477 at ruby.c:1754
    frame #11: 0x00000001002122dd miniruby`ruby_process_options(argc=2, argv=0x00007fff5fbfdbf8) + 285 at ruby.c:2332
    frame #12: 0x00000001000aa966 miniruby`ruby_options(argc=2, argv=0x00007fff5fbfdbf8) + 262 at eval.c:118
    frame #13: 0x0000000100000ed4 miniruby`main(argc=2, argv=0x00007fff5fbfdbf8) + 116 at main.c:42
    frame ruby#14: 0x00007fff933845ad libdyld.dylib`start + 1
    frame ruby#15: 0x00007fff933845ad libdyld.dylib`start + 1
(lldb)


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65148 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@shyouhei shyouhei force-pushed the trunk branch 20 times, most recently from 9d6ae10 to f875cdf Compare October 22, 2018 01:23
@shyouhei
Copy link
Owner

shyouhei commented Feb 12, 2019

Let me close this ages ticket. If you still need this file another one at https://github.com/ruby/ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.