Multiple cdn modules for multiple pages app#13
Merged
shirotech merged 5 commits intoshirotech:masterfrom Jan 31, 2018
likun7981:master
Merged
Multiple cdn modules for multiple pages app#13shirotech merged 5 commits intoshirotech:masterfrom likun7981:master
shirotech merged 5 commits intoshirotech:masterfrom
likun7981:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 45 58 +13
=====================================
+ Hits 45 58 +13 |
Owner
|
@likun7981 This is a very good feature indeed. Nice one! Thank you for contributing, I have reviewed and seems good to merge after removing some comment debug code. Also I think Also if you have some time, just need to update the docs on |
Contributor
Author
|
Updated |
shirotech
approved these changes
Jan 31, 2018
module.js
Outdated
| const mods = this.modules[key]; | ||
| mods.forEach((p) => { | ||
| // if (externals[p.name]) { | ||
| // console.warn(`The key '${p.name}' of module ${key === DEFAULT_MODULE_KEY ? '' : `'${key}'`} already exists `); // eslint-disable-line |
Owner
There was a problem hiding this comment.
If you don't mind, can you please remove comment code? Thanks. Rest seems good to merge 👍
Owner
|
Merged and published :) |
|
Impressive solution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webpack.config.js
cdnModulethis value, the default is to take the first onecdnModule = false, it will not inject cdnDo not worry, it is still compatible with the previous configuration 😀