Skip to content

enable supportsSystemThemeChanges() for all Linux builds #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shiftkey merged 1 commit into from
Feb 23, 2022
Merged

enable supportsSystemThemeChanges() for all Linux builds #663

shiftkey merged 1 commit into from
Feb 23, 2022

Conversation

@shiftkey
Copy link
Owner

@shiftkey shiftkey commented Feb 22, 2022 •
edited
Loading

Resolves #372
Resolves #512

Description

Enabling the supportsSystemThemeChanges() change on Linux seems to handle the two cases that were reported earlier:

  • inherit from the system theme if set
  • changing the theme should not require a restart

Screenshots

With "System" chosen and dark theme selected

With "System" chosen and light theme selected

Release notes

Notes: enable system theme and synchronising with current OS light/dark theme

@shiftkey shiftkey merged commit 83ae586 into linux Feb 23, 2022
@shiftkey shiftkey deleted the enable-theme-detection branch February 23, 2022 12:57
shiftkey added a commit that referenced this pull request Feb 23, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
fa7f8b8
shiftkey added a commit that referenced this pull request Mar 12, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
9740d5e
shiftkey added a commit that referenced this pull request Apr 3, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
5f409a0
shiftkey added a commit that referenced this pull request Apr 3, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
1f8db72
shiftkey added a commit that referenced this pull request Apr 3, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
4383073
shiftkey added a commit that referenced this pull request Apr 3, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
7f7af6e
shiftkey added a commit that referenced this pull request Apr 3, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
da7a87d
shiftkey added a commit that referenced this pull request Apr 3, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
f3ae294
shiftkey added a commit that referenced this pull request Apr 3, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
a8cced5
shiftkey added a commit that referenced this pull request Apr 8, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
334aa84
shiftkey added a commit that referenced this pull request Apr 15, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
e691d4f
shiftkey added a commit that referenced this pull request Apr 15, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
9df8d7d
shiftkey added a commit that referenced this pull request Apr 15, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
0d9d669
shiftkey added a commit that referenced this pull request Apr 15, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
b3da869
shiftkey added a commit that referenced this pull request Apr 15, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
64c3bad
shiftkey added a commit that referenced this pull request Apr 21, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
8d20a23
shiftkey added a commit that referenced this pull request Apr 21, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
ec0ed07
shiftkey added a commit that referenced this pull request Apr 21, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
a42d4c7
shiftkey added a commit that referenced this pull request Apr 27, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
84e386d
shiftkey added a commit that referenced this pull request Apr 27, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
6c247ef
shiftkey added a commit that referenced this pull request Apr 27, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
9202787
shiftkey added a commit that referenced this pull request Jun 11, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
b73c7a9
shiftkey added a commit that referenced this pull request Oct 15, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
c50b9ae
shiftkey added a commit that referenced this pull request Oct 15, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
1effd7d
shiftkey added a commit that referenced this pull request Nov 19, 2022
@shiftkey
opt-in Linux builds to theme changes too (#663)
7189c8a
shiftkey added a commit that referenced this pull request Jan 29, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
a4747b9
shiftkey added a commit that referenced this pull request Jan 29, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
a3fed34
shiftkey added a commit that referenced this pull request Jan 29, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
c41c230
shiftkey added a commit that referenced this pull request Jan 29, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
70442ab
shiftkey added a commit that referenced this pull request Jan 29, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
a0c6c94
shiftkey added a commit that referenced this pull request Jan 29, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
b7e1290
shiftkey added a commit that referenced this pull request Jan 29, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
528f416
shiftkey added a commit that referenced this pull request Jan 29, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
21b3288
shiftkey added a commit that referenced this pull request Jan 29, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
ccb7f2f
shiftkey added a commit that referenced this pull request Feb 17, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
89b8d56
shiftkey added a commit that referenced this pull request Feb 17, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
711ff77
shiftkey added a commit that referenced this pull request Feb 17, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
868efd1
shiftkey added a commit that referenced this pull request Feb 17, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
a6ba2ba
shiftkey added a commit that referenced this pull request Feb 17, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
11c8525
shiftkey added a commit that referenced this pull request Feb 26, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
881539f
shiftkey added a commit that referenced this pull request Feb 26, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
ac3350d
shiftkey added a commit that referenced this pull request Feb 26, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
fc99cf2
shiftkey added a commit that referenced this pull request Mar 1, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
1d5b553
shiftkey added a commit that referenced this pull request Mar 1, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
05a1609
shiftkey added a commit that referenced this pull request Mar 2, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
70e20bc
shiftkey added a commit that referenced this pull request Mar 15, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
56debfa
shiftkey added a commit that referenced this pull request Apr 4, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
0dec320
shiftkey added a commit that referenced this pull request Apr 7, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
2221494
shiftkey added a commit that referenced this pull request Apr 7, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
050a7a8
shiftkey added a commit that referenced this pull request Apr 7, 2023
@shiftkey
opt-in Linux builds to theme changes too (#663)
57ae6d7
theofficialgman pushed a commit to theofficialgman/desktop that referenced this pull request Jun 4, 2023
@shiftkey @theofficialgman
opt-in Linux builds to theme changes too (shiftkey#663)
bed0716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

changing theme needs restart Use system theme via matchMedia for auto dark mode option

2 participants

@shiftkey