Skip to content

move icons to correct location, update usages in tooling#606

Merged
shiftkey merged 1 commit intolinuxfrom
move-icons-to-correct-directory
Oct 3, 2021
Merged

move icons to correct location, update usages in tooling#606
shiftkey merged 1 commit intolinuxfrom
move-icons-to-correct-directory

Conversation

@shiftkey
Copy link
Owner

@shiftkey shiftkey commented Oct 3, 2021 •
edited
Loading

Resolves #559

Thanks to @sarim for identifying the root cause.

The bit that I'd forgotten as part of this is that static assets need to be defined in a platform-specific subdirectory to be included as part of the app package - app/static/win32 for Windows, app/static/darwin for macOS and app/static/linux for Linux.

This is the relevant code that does the actual copying:

desktop/script/build.ts

Lines 253 to 255 in c7c2cf6

if (fs.existsSync(platformSpecific)) {
fs.copySync(platformSpecific, destination)
}

app/static/logos is only used at packaging time, which is why things were working sometimes.

I also found out that the icon option for electron-packager is not supported on Linux, so I've updated that area to be clearer.

@shiftkey shiftkey force-pushed the move-icons-to-correct-directory branch from fa8f82c to 9543083 Compare October 3, 2021 21:25
@shiftkey shiftkey merged commit 2587066 into linux Oct 3, 2021
@shiftkey shiftkey deleted the move-icons-to-correct-directory branch October 3, 2021 21:49
shiftkey added a commit that referenced this pull request Oct 3, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
482115c
shiftkey added a commit that referenced this pull request Oct 7, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
67fa7d4
shiftkey added a commit that referenced this pull request Oct 22, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
2b56022
shiftkey added a commit that referenced this pull request Oct 22, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
b351bde
shiftkey added a commit that referenced this pull request Oct 22, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
dffc161
shiftkey added a commit that referenced this pull request Nov 4, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
f33c866
shiftkey added a commit that referenced this pull request Nov 27, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
f2ce205
shiftkey added a commit that referenced this pull request Dec 18, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
b9124a1
shiftkey added a commit that referenced this pull request Dec 18, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
ceaa497
shiftkey added a commit that referenced this pull request Dec 18, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
db6a786
shiftkey added a commit that referenced this pull request Dec 18, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
f20520b
shiftkey added a commit that referenced this pull request Dec 18, 2021
@shiftkey
move icons to correct location, update usages in tooling (#606)
924aefe
shiftkey added a commit that referenced this pull request Feb 5, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
a316746
shiftkey added a commit that referenced this pull request Feb 22, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
5c36274
shiftkey added a commit that referenced this pull request Feb 22, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
2254514
shiftkey added a commit that referenced this pull request Feb 22, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
3013e27
shiftkey added a commit that referenced this pull request Feb 22, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
c524e64
shiftkey added a commit that referenced this pull request Feb 22, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
fec18ea
shiftkey added a commit that referenced this pull request Feb 22, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
5a9c4a0
shiftkey added a commit that referenced this pull request Feb 22, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
47bacdf
shiftkey added a commit that referenced this pull request Mar 12, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
5526b80
shiftkey added a commit that referenced this pull request Apr 3, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
2f16791
shiftkey added a commit that referenced this pull request Apr 3, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
f3782f5
shiftkey added a commit that referenced this pull request Apr 15, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
6cd28ed
shiftkey added a commit that referenced this pull request Apr 15, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
8ea3e01
shiftkey added a commit that referenced this pull request Apr 15, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
d2b2cb7
shiftkey added a commit that referenced this pull request Apr 15, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
7f4cf00
shiftkey added a commit that referenced this pull request Apr 21, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
17fcf26
shiftkey added a commit that referenced this pull request Apr 21, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
3e785b0
shiftkey added a commit that referenced this pull request Apr 21, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
6b0fd51
shiftkey added a commit that referenced this pull request Apr 27, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
6d6f1c5
shiftkey added a commit that referenced this pull request Apr 27, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
9870bc9
shiftkey added a commit that referenced this pull request Apr 27, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
00e8184
shiftkey added a commit that referenced this pull request Jun 11, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
900b739
shiftkey added a commit that referenced this pull request Jun 11, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
098cbec
shiftkey added a commit that referenced this pull request Jun 11, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
48dba23
shiftkey added a commit that referenced this pull request Jun 25, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
b9923c8
shiftkey added a commit that referenced this pull request Jun 25, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
ff3ac52
shiftkey added a commit that referenced this pull request Jun 25, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
112af3b
shiftkey added a commit that referenced this pull request Jul 6, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
24d758f
shiftkey added a commit that referenced this pull request Jul 6, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
04de28f
shiftkey added a commit that referenced this pull request Jul 6, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
2f23bce
shiftkey added a commit that referenced this pull request Jul 26, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
ce835a0
shiftkey added a commit that referenced this pull request Jul 26, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
78c77bc
shiftkey added a commit that referenced this pull request Jul 26, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
89f6675
shiftkey added a commit that referenced this pull request Jul 26, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
667cec9
shiftkey added a commit that referenced this pull request Aug 2, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
3f11d71
shiftkey added a commit that referenced this pull request Aug 2, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
9f7dcaa
shiftkey added a commit that referenced this pull request Sep 6, 2022
@shiftkey
move icons to correct location, update usages in tooling (#606)
30b0e0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

After installation 2.9.0 icon does not appear

1 participant

@shiftkey