Skip to content

allow tilde character when specifying a local repository#317

Merged
shiftkey merged 1 commit intoshiftkey:linuxfrom
Daniel-McCarthy:Allow-Add-Existing-Repository-To-Validate-Home-Tilde-Paths
Aug 4, 2020
Merged

allow tilde character when specifying a local repository#317
shiftkey merged 1 commit intoshiftkey:linuxfrom
Daniel-McCarthy:Allow-Add-Existing-Repository-To-Validate-Home-Tilde-Paths

Conversation

@Daniel-McCarthy
Copy link

@Daniel-McCarthy Daniel-McCarthy commented Jul 30, 2020 •
edited
Loading

Fixes #294

Description

  • Uses resolved path (which uses untildify to convert our path into an absolute path) when checking if the path is a git repository so that it will find the repository path and validate correctly.

Screenshots

image

Notes:

On the original issue there was discussion about potential concerns on why this functionality already existed but was not being used on the onPathChanged function.

Upon looking into the git history, this is what I found:

  • This commit introduced untildify to the checkIfPathIsRepository function, feeding the absolute path to isGitRepository.
  • This series of commits moved this functionality into the resolvedPath function we have today. [1][2][3]
  • This commit removed the checkIfPathIsRepository function that included the resolvedPath call that was used, and introduced the isGitRepository function directly to the onPathChanged function, thus losing our home path support.

It appears to me that this change was unintentional, and not part of a testing issue. I have been able to check that the change is working as expected on my linux installation, and would love to test and make sure it works as intended on Windows soon.

@Daniel-McCarthy
Allow Add-Existing-Repository to validate home/tilde paths
e059945 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed duringa commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
@shiftkey shiftkey changed the title Allow Add-Existing-Repository to validate home/tilde paths allow tilde character when specifying a local repository Aug 4, 2020
shiftkey
shiftkey approved these changes Aug 4, 2020
View reviewed changes
Copy link
Owner

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Daniel-McCarthy!

I tested this out on macOS and it too doesn't seem to accept a ~ in a valid path:

Switching to the full path enables the button again:

This suggests that we might need to fix this upstream, and include some regression tests, but for now I'm happy to land this fix and include it with the next update for Linux.

@shiftkey shiftkey merged commit 052fa14 into shiftkey:linux Aug 4, 2020
@shiftkey shiftkey mentioned this pull request Aug 4, 2020
Closed
@Daniel-McCarthy Daniel-McCarthy deleted the Allow-Add-Existing-Repository-To-Validate-Home-Tilde-Paths branch August 4, 2020 12:22
shiftkey pushed a commit that referenced this pull request Aug 19, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
4732bb7 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Aug 24, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
cbf5fed 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Aug 27, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
f82027e 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Aug 27, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
a12a82f 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Aug 27, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
a8806d0 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Nov 6, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
67f158e 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Nov 6, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
dd0a8a7 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Nov 6, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
78a37d8 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Nov 6, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
fd25837 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Nov 6, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
264bf08 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Nov 6, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
7dc5983 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Nov 6, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
6cc7b2c 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Nov 6, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
a2917a3 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Nov 11, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
b14aa06 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Dec 11, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
e37edfb 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Dec 17, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
c32a4bd 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Dec 17, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
2ac724f 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Dec 17, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
d0f6969 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Dec 17, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
6ee00ed 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Dec 17, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
14849dc 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Dec 18, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
b0662df 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Dec 27, 2020
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
b444662 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Feb 11, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
f941f0e 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Feb 14, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
b77b86e 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Feb 15, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
1205a71 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Feb 15, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
f03f6d8 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Feb 25, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
9569dec 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Mar 8, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
22e9d96 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Mar 8, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
14fc050 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Mar 8, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
ddf2e3f 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Mar 11, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
e83e97b 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Mar 11, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
c0009d0 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Mar 11, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
4106150 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Mar 25, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
57b4f0c 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Mar 30, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
d864030 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Mar 30, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
f8994c5 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Mar 30, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
7910675 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Apr 3, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
a6f0c84 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Apr 8, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
6467129 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Apr 8, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
cd03aa1 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Apr 8, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
82539ad 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Apr 17, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
4dc58d3 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Apr 23, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
1b7ce8c 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Apr 28, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
c57fc9e 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Apr 28, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
1585563 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request Apr 28, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
b893f62 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
shiftkey pushed a commit that referenced this pull request May 6, 2021
@Daniel-McCarthy @shiftkey
allow tilde character when specifying a local repository (#317)
d60fe27 
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
@shiftkey shiftkey mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shiftkey shiftkey shiftkey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

missing tilde interpolation for local paths

2 participants

@Daniel-McCarthy @shiftkey