Merged
Conversation
… order to merge to master.
libomp.so is missing on travis, and this is a known issue. travis-ci/travis-ci#8613
…he compiler is Clang. This is because compilation of unroll_0_vecextqp.c does not finish.
xoofx
approved these changes
Dec 2, 2017
Fixed compilation errors that were happening in rare cases.
fpetrogalli
pushed a commit
that referenced
this pull request
Dec 4, 2017
After the merge of #112, `libdft` gets compiled and tested via cmake, so there is no need to have this Makefile compilation of `libdft`.
This was referenced Dec 4, 2017
fpetrogalli
pushed a commit
that referenced
this pull request
Dec 5, 2017
After the merge of #112, `libdft` gets compiled and tested via cmake, so there is no need to have this Makefile compilation of `libdft`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commiting the changes for adding CMakeLists.txts for libdft again, in order to merge to master.
Most of the comments in the last pull request are now reflected.
It still needs to turn off support for openmp and float128 if it is running on Travis and the compiler is clang.