Introducing sample2: fix potential sampling bias issue and ensure deterministic -n behavior#566
Merged
shenwei356 merged 5 commits intoshenwei356:masterfrom Jan 4, 2026
Merged
Conversation
Owner
|
Thanks ! |
Owner
|
Thanks a lot! |
Contributor
Author
|
You're welcome! Glad to contribute to the project. |
shenwei356
added a commit
that referenced
this pull request
Jan 4, 2026
Owner
|
I've also updated the help message to recommend users to use |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new subcommand
sample2to address a few issues in the existingsamplesubcommand:Problems with existing
sample -nThe current implementation uses proportion-based Bernoulli sampling with an amplification factor and early termination. This approach has several limitations:
-2) with proportion sampling (-p) doesn't provide explicit number control.sample2subcommand solution-n -2(Reservoir sampling for fixed-size sampling)-n(Partial in-memory shuffle)-p -2(Two-pass reservoir sampling)-pis specified with-2floor(p × n)-p(Original behavior)Backward compatibility
The original
samplesubcommand remains unchanged to ensure backward compatibility.