doc(grep): clarify help text on how to pass multiple patterns#527
Merged
shenwei356 merged 1 commit intoshenwei356:masterfrom Jul 14, 2025
Merged
doc(grep): clarify help text on how to pass multiple patterns#527shenwei356 merged 1 commit intoshenwei356:masterfrom
shenwei356 merged 1 commit intoshenwei356:masterfrom
Conversation
It took me a minute or so to figure out how to pass multiple patterns. This PR provides explicit examples on the syntax to pass multiple strings.
Owner
|
Great! Can use a variable to replace the command part. |
Contributor
Author
|
@shenwei356 great to hear you are interested in the changes.
I'm not 100% clear what you mean by this. Do you mean that we should use a variable to use in all 3 places where that help text would appear? |
Owner
|
Yes. But just part of the help message, ideally --- the examples. |
shenwei356
added a commit
that referenced
this pull request
Jul 14, 2025
Owner
|
Thank you Cornelius. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me a minute or so to figure out how to pass multiple patterns.
This PR provides explicit examples on the syntax to pass multiple strings.
The (almost) same text also appears in the
locate,mutate,replacesubcommands. These could be changed as well - either in this or a future PR (and the help text potentially put in a single place to keep things DRY).