Make shell.exec() treat process error return codes as shelljs errors#80
Merged
arturadib merged 1 commit intoshelljs:masterfrom Sep 9, 2013
Merged
Make shell.exec() treat process error return codes as shelljs errors#80arturadib merged 1 commit intoshelljs:masterfrom
arturadib merged 1 commit intoshelljs:masterfrom
Conversation
Collaborator
|
Looks great, thanks! |
arturadib
added a commit
that referenced
this pull request
Sep 9, 2013
Make shell.exec() treat process error return codes as shelljs errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes shell.exec() handle error return codes the same way as other shelljs errors -- by calling common.error(). Especially in fatal mode, this makes error handling of exec more consistent with other shelljs functions.
To test, I temporarily override process.exit(), then put it back... let me know if you have any better suggestions :)