Conversation
nfischer
requested changes
Mar 8, 2017
Member
nfischer
left a comment
There was a problem hiding this comment.
LGTM aside from my one comment
test/utils/utils.js
Outdated
|
|
||
| function mkfifo(dir) { | ||
| if (process.platform !== 'win32') { | ||
| const fifo = `${dir}/fifo`; |
Member
There was a problem hiding this comment.
Can you use regular string concatenation? This doesn't work for v0.12
nfischer
approved these changes
Mar 8, 2017
Member
|
FFTM if CI passes |
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 94.32% 94.34% +0.01%
==========================================
Files 33 33
Lines 1180 1184 +4
==========================================
+ Hits 1113 1117 +4
Misses 67 67
Continue to review full report at Codecov.
|
Contributor
Author
|
CI failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for removing fifos.
Fixes #617