Skip to content

chore: add codecov script to appveyor CI#686

Merged
freitagbr merged 1 commit intomasterfrom
test-coverage-appveyor
Mar 5, 2017
Merged

chore: add codecov script to appveyor CI#686
freitagbr merged 1 commit intomasterfrom
test-coverage-appveyor

Conversation

@nfischer
Copy link
Copy Markdown
Member

@nfischer nfischer commented Mar 5, 2017

Invoke codecov on appveyor builds too, so that we can get coverage for
Windows-specific lines of code.

Partial fix for #671

@nfischer nfischer added the test label Mar 5, 2017
@nfischer nfischer added this to the v0.7.x milestone Mar 5, 2017
@nfischer nfischer requested a review from freitagbr March 5, 2017 09:28
@nfischer
Copy link
Copy Markdown
Member Author

nfischer commented Mar 5, 2017

This is a test to see if codecov is additive: will running codecov on both Windows and Unix take the union of the lines covered? This would be very beneficial for us, so that we can cover lines which handle different versions of Node.js and which handle different platforms.

If this is successful, then we should see that code coverage improves, particularly for commands with lots of Windows-specific code, such as which(). Once codecov is done, we should be able to go to the shelljs page and view coverage for this particular branch.

@nfischer nfischer force-pushed the test-coverage-appveyor branch from 891d598 to 30006dd Compare March 5, 2017 09:44
@nfischer
Copy link
Copy Markdown
Member Author

nfischer commented Mar 5, 2017

Looks like the codecov package relies on the unix find command, which is very different than the Windows FIND command. Looks like codecov has disappointed me once again... Hopefully this is something they're working on.

@nfischer nfischer removed this from the v0.7.x milestone Mar 5, 2017
Invoke codecov on appveyor builds too, so that we can get coverage for
Windows-specific lines of code.

Partial fix for #671
@nfischer nfischer force-pushed the test-coverage-appveyor branch from 30006dd to 18b4b82 Compare March 5, 2017 10:04
@nfischer
Copy link
Copy Markdown
Member Author

nfischer commented Mar 5, 2017

Ok, I think appveyor works now. The tricks I needed were:

  • wrap the codecov command with npm run codecov (avoids a command-not-found error)
  • specify the lcov.info file with codecov's -f flag

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 5, 2017

Codecov Report

Merging #686 into master will increase coverage by 1.61%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #686      +/-   ##
=========================================
+ Coverage   92.68%   94.3%   +1.61%     
=========================================
  Files          33      33              
  Lines        1176    1176              
=========================================
+ Hits         1090    1109      +19     
+ Misses         86      67      -19
Impacted Files Coverage Δ
src/cp.js 90.09% <0%> (+1.8%)
src/rm.js 100% <0%> (+2.12%)
src/common.js 96.62% <0%> (+2.24%)
src/ls.js 100% <0%> (+2.38%)
src/ln.js 100% <0%> (+3.12%)
src/find.js 100% <0%> (+4.34%)
src/mv.js 97.29% <0%> (+5.4%)
src/toEnd.js 100% <0%> (+9.09%)
src/which.js 94.73% <0%> (+15.78%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346fca4...18b4b82. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants