tempdir: use os.tmpDir when possible#67
tempdir: use os.tmpDir when possible#67arturadib merged 2 commits intoshelljs:masterfrom stephenmathieson:os-dot-tmpdir
os.tmpDir when possible#67Conversation
test/tempdir.js
Outdated
There was a problem hiding this comment.
hmm I think this test is unnecessary -- from the user's viewpoint, it doesn't matter what exactly the temp dir, all they want is a writeable temp directory.
There was a problem hiding this comment.
Good point; I'll revert this tonight.
On Jun 11, 2013, at 3:27 PM, Artur Adib wrote:
In test/tempdir.js:
@@ -21,6 +22,10 @@ shell.mkdir('tmp');
//var tmp = shell.tempdir();
+// node 0.8+
hmm I think this test is unnecessary -- from the user's viewpoint, it doesn't matter what exactly the temp dir, all they want is a writeable temp directory.—
Reply to this email directly or view it on GitHub.
|
@arturadib thoughts? should i close? |
|
sorry Stephen, I'm on paternity leave and not online very much. thanks that looks great! |
tempdir: use `os.tmpDir` when possible
|
no problem and congrats! :) |
use node's native
tmpDirwhen possible, but fallback to the python's algorithm in old (really old) versions of node