Conversation
freitagbr
requested changes
Feb 17, 2017
RELEASE.md
Outdated
| - `$ git push` | ||
| 5. Generate the documentup website by visiting | ||
| [http://documentup.com/shelljs/shelljs/__recompile] in your browser | ||
| 1. Generate the documentup website by visiting |
Contributor
There was a problem hiding this comment.
The numbers need to be incremented.
Member
Author
There was a problem hiding this comment.
Sure. For what it's worth, the number can actually be anything, it doesn't have to increment. Here are the official docs and here is a guide which demonstrates that.
I've seen the 1-only style preferred other places. I suppose this might likely be read in the terminal, so the real numbers might be more helpful.
Contributor
There was a problem hiding this comment.
Wow, I had no idea that was a thing!
Miscellaneous changes.
f4f181b to
7b52dd8
Compare
Member
Author
|
@freitagbr PTAL |
Contributor
|
LGTM |
freitagbr
approved these changes
Feb 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous changes.
npm run gendocsis actually done as part of the CI, so it isn't necessary to run it manually for a release.