Merged
Conversation
freitagbr
reviewed
Jan 17, 2017
Contributor
freitagbr
left a comment
There was a problem hiding this comment.
Maybe we should leave a note in the README that starting with v0.8, we are only supporting Node v4+? Also, is everything on dev slated for v0.8?
Member
Author
|
@freitagbr I updated the README to mention v4+. I don't think it's necessary to mention this corresponds with v0.8, since that'll be the version once we merge dev into master. |
Member
Author
|
And yes, dev branch contains changes for v0.8. Once we get close to a release, we can merge into master and do the finishing touches on the master branch. Postponing the merge is helpful, otherwise v0.8 docs will show up on the README before it's released. |
freitagbr
approved these changes
Jan 17, 2017
Contributor
|
LGTM, needs a rebase off of |
Member
Author
|
Updated with Github UI. Should be fine, since it all squashes anyway. |
freitagbr
pushed a commit
that referenced
this pull request
Jun 7, 2017
Merged
nfischer
added a commit
that referenced
this pull request
Jun 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #647