Conversation
Use nyc for test coverage and ignore all nyc-related files in git & eslint. This increases testing time (~35sec -> ~60sec on my 4-core machine).
Member
Author
|
This is a regression in testing time, so I'll leave it to @freitagbr's discretion as to whether to merge. The real benefit will be once we set up coveralls or codecov for this project. Codecov seems to be mostly broken for shx right now, and I haven't had time to look into it yet, so I have no issues with using coveralls if that's preferred. |
Contributor
|
I think the code coverage report is useful, and the increase in testing time is not that great. Let's go for it. |
freitagbr
approved these changes
Dec 28, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
nycfor test coverage and ignore all nyc-related files in git & eslint.This increases testing time (~35sec -> ~60sec on my 4-core machine).
Fixes #347