-
Notifications
You must be signed in to change notification settings - Fork 744
Improve test coverage #347
Description
This is a general issue that our unit tests should be more comprehensive. I've noticed that sometimes unit tests don't actually test correct behavior (this was the issue with some tests in touch.js that I fixed. I'm sure there are also many options/edge cases for functions that are not tested very comprehensively.
As we work toward future releases, we should also work on improving our test framework, to prevent regressions. Also, we should probably add more sanity checks in the run-tests.js script, since because this uses ShellJS to test ShellJS, a major break (for example: if ls() returns the empty array every time) can cause the test runner to give a false positive.
I'm putting the "help wanted" label on here, so if anyone is looking for something to contribute on, more test cases would be welcome.
If you'd like to contribute, please try to isolate your changes to one file per PR (it makes it much easier to review). Also, it helps if you tag this issue number in your PR. We're also interested in refactoring test cases (so as long as you know JS, you'd be able to help) 👍